'Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPriva'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPriva
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2015-03-22 17:18:27
Message-ID: 20150322171827.548.26992 () mimi ! kde ! org
[Download RAW message or body]

--===============8629751989854445218==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/
-----------------------------------------------------------

(Updated March 22, 2015, 5:18 p.m.)

Review request for KDE Frameworks.

Changes
-------

Change code as suggested by David, also added test.

Repository: kio

Description
-------

The rest of kio internally is doing this correctly apparently it was only a problem \
in the GUI part of it.

Diffs (updated)
-----

  autotests/kurlcomboboxtest.h PRE-CREATION 
  autotests/kurlcomboboxtest.cpp PRE-CREATION 
  src/widgets/kurlcombobox.cpp ed5b8a2 

Diff: https://git.reviewboard.kde.org/r/122613/diff/

Testing
-------

Besides the added unit tests, I have used this patch while running a few ups, \
everything seems to work great.

Thanks,

Àlex Fiestas

--===============8629751989854445218==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122613/">https://git.reviewboard.kde.org/r/122613/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated March 22, 2015, 5:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change code as suggested by David, also added test.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The rest of kio internally is doing this correctly \
apparently it was only a problem in the GUI part of it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Besides the added unit tests, I have used this patch \
while running a few ups, everything seems to work great.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kurlcomboboxtest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/kurlcomboboxtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/widgets/kurlcombobox.cpp <span style="color: grey">(ed5b8a2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122613/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8629751989854445218==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 