[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122970: Move added setError method to org.kde.JobView.xml
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-03-21 13:07:33
Message-ID: 20150321130733.3832.1707 () mimi ! kde ! org
[Download RAW message or body]
--===============5671125461731710440==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 21, 2015, 12:55 p.m., David Faure wrote:
> > Yep (looks like you posted a followup commit rather than merging the two, and the \
> > commit log on reviewboard is outdated, it still talks about V3). But if you make \
> > sure to review and clean up the commit, you can commit.
I updated the diff from website. I will only commit the current diff, not multiple \
commits.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122970/#review77880
-----------------------------------------------------------
On March 21, 2015, 1:07 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122970/
> -----------------------------------------------------------
>
> (Updated March 21, 2015, 1:07 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kjobwidgets
>
>
> Description
> -------
>
> Reuse org.kde.JobView.xml file that is no longer used anywhere. It now contains the \
> current org.kde.JobViewV2 interface spec. org.kde.JobViewV2.xml is still available, \
> but only for backwards compatibility.
> This fixes source compatibility from 812d0b440e7f08e3acdd1c9bb95779bd871b75b3
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c539bdc
> src/kuiserverjobtracker.cpp 7f13a4d
> src/kuiserverjobtracker_p.h daf3902
> src/org.kde.JobView.xml f64d232
> src/org.kde.JobViewV2.xml 245a5f0
>
> Diff: https://git.reviewboard.kde.org/r/122970/diff/
>
>
> Testing
> -------
>
> plasma-workspace stable now builds fine
> changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError \
> method.
>
> Thanks,
>
> David Rosca
>
>
--===============5671125461731710440==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122970/">https://git.reviewboard.kde.org/r/122970/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 21st, 2015, 12:55 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yep (looks like you posted a followup commit rather \
than merging the two, and the commit log on reviewboard is outdated, it still talks \
about V3). But if you make sure to review and clean up the commit, you can \
commit.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
updated the diff from website. I will only commit the current diff, not multiple \
commits.</p></pre> <br />
<p>- David</p>
<br />
<p>On March 21st, 2015, 1:07 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 21, 2015, 1:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjobwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Reuse org.kde.JobView.xml file that is no longer used \
anywhere. It now contains the current org.kde.JobViewV2 interface spec. \
org.kde.JobViewV2.xml is still available, but only for backwards compatibility.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes source compatibility from \
812d0b440e7f08e3acdd1c9bb95779bd871b75b3</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasma-workspace stable now builds fine changing V2 \
-> V3 in CMakeFiles.txt in master branch enable the new setError method.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(c539bdc)</span></li>
<li>src/kuiserverjobtracker.cpp <span style="color: grey">(7f13a4d)</span></li>
<li>src/kuiserverjobtracker_p.h <span style="color: grey">(daf3902)</span></li>
<li>src/org.kde.JobView.xml <span style="color: grey">(f64d232)</span></li>
<li>src/org.kde.JobViewV2.xml <span style="color: grey">(245a5f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5671125461731710440==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic