[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2015-03-07 11:49:05
Message-ID: 20150307114905.22965.89124 () probe ! kde ! org
[Download RAW message or body]
--===============8248629044753327160==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122620/#review77164
-----------------------------------------------------------
ping
src/ioslaves/http/http.h
<https://git.reviewboard.kde.org/r/122620/#comment53015>
use a better comment
- Emmanuel Pescosta
On Feb. 18, 2015, 11:05 a.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122620/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:05 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Implement quota-used-bytes and quota-available-bytes from RFC 4331 to enable free \
> space information in http ioslave.
>
> Diffs
> -----
>
> src/ioslaves/http/http.h f0dc027
> src/ioslaves/http/http.cpp 78f50f9
>
> Diff: https://git.reviewboard.kde.org/r/122620/diff/
>
>
> Testing
> -------
>
> Tested with Owncloud (share.kde.org)
>
>
> File Attachments
> ----------------
>
> webdav_freespace.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/c90a8f70-e12b-44b3-a0b8-651f1ee7d602__webdav_freespace.png
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============8248629044753327160==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122620/">https://git.reviewboard.kde.org/r/122620/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122620/diff/1/?file=350130#file350130line516" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ioslaves/http/http.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">516</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">fileSystemFreeSpace</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QUrl</span> <span \
class="o">&</span><span class="n">url</span><span class="p">);</span> <span \
class="c1">// KF6 </span><span class="cs">TODO</span><span class="c1">: Turn into \
virtual method in SlaveBase</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use a \
better comment</p></pre> </div>
</div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On February 18th, 2015, 11:05 a.m. CET, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2015, 11:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implement quota-used-bytes and quota-available-bytes \
from RFC 4331 to enable free space information in http ioslave.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with Owncloud (share.kde.org)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/http.h <span style="color: grey">(f0dc027)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(78f50f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122620/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/c90a8f70 \
-e12b-44b3-a0b8-651f1ee7d602__webdav_freespace.png">webdav_freespace.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8248629044753327160==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic