[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122706: A KCModule base for QML based KCMs
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2015-02-25 21:53:52
Message-ID: 20150225215352.12884.12661 () probe ! kde ! org
[Download RAW message or body]
--===============0807149577253761577==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 24, 2015, 10:59 a.m., David Edmundson wrote:
> > src/kcmoduleqml.h, line 36
> > <https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36>
> >
> > When we do make a QML only system settings we're not going to want to use \
> > KCMModule at all, even if it's not shown?
> > I imagine we'll end up writing a small QObject shim that copies the API.
> >
> > I'd just leave this until we find we need it, otherwise we're committing to a \
> > slightly weird API prematurely.
>
> Marco Martin wrote:
> I can move it out for now, but i don't think is realistic to expect to port \
> everything away from kcmmodule overnight. porting all to this will be hard enough \
> already, reporting a second time i think is really a framework6 thing. If there \
> will exist a qml based systemsettings, it will have to be able to load things all \
> the way in the transition spectrum: old qwidget ones and those, which can ignore \
> the qwidget part. It's clearly transitional but i don't think there is a way to \
> realistically have qobject only ones before there is something working in place?
> Marco Martin wrote:
> Thinking about it, one way that and almost legacyless way could be done is:
> having in a separate library, tier2 a qobject based thing that has an api similar \
> to kcmodule, and doing the qml kcms directly in that. then this class goes in \
> pretty similar, except the plugins wouldn't subclass it, but would be used directly \
> to load one of those qobject only thinghies. the disadvantage would be that \
> systemsettings, kcmshell (and pretty much any app config dialog that loads kcms) \
> would have to directly special case for this, so the transition would be more \
> painful.
> Sebastian Kügler wrote:
> Makes sense. I think we can combine the two approaches.
>
> * New-style QML "KCMs" do not link KCModule directly, but rather use the imports \
> you describe.
> * A special-sauce KCM does the necessary bits to load these new-style KCMs (pretty \
> much what this patch does, really)
> That way, we allow legacy-free new-style, but make it compatible with everything \
> old-style, QWidget-based KCMs, systemsettings, kcmshell, etc.
> A new "systemsettings-qml" would have to be special-cased in order to also load \
> KCModule/QWidget-based modules, but I don't think there's any way around that \
> anyway.
The architecture of System Settings should allow it to host native QML KCMs without \
having to use the KCModule class, assuming the appropriate changes are made.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122706/#review76534
-----------------------------------------------------------
On Feb. 25, 2015, 5:40 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122706/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:40 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> this adds a new class called KCModuleQml
> it loads a KPackage with the same plugin name as the kcm, then loads its mainscript \
> qml file from it and puts it in a QQuickView used as main widget of the KCM.
> It supports two ways of loading the qml:
> one is in the showevent of the KCM qwidget, this is compatible with current \
> Systemsettings and kcmshell. the other way is with the mainUi accessor/qproperty. \
> This will make possible for a pure QML version of systemsettings (accessing \
> directly mainUi without showing qwidgets)
>
> Diffs
> -----
>
> CMakeLists.txt f3aaf18
> src/CMakeLists.txt 10862c6
> src/kcmoduleqml.h PRE-CREATION
> src/kcmoduleqml.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122706/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============0807149577253761577==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122706/">https://git.reviewboard.kde.org/r/122706/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2015, 10:59 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kcmoduleqml.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QQuickItem</span> <span class="o">*</span><span \
class="nf">mainUi</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When \
we do make a QML only system settings we're not going to want to use KCMModule at \
all, even if it's not shown?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I imagine we'll end up writing a small \
QObject shim that copies the API.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd just leave this \
until we find we need it, otherwise we're committing to a slightly weird API \
prematurely.</p></pre> </blockquote>
<p>On February 24th, 2015, 11:07 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
move it out for now, but i don't think is realistic to expect to port everything away \
from kcmmodule overnight. porting all to this will be hard enough already, reporting \
a second time i think is really a framework6 thing. If there will exist a qml based \
systemsettings, it will have to be able to load things all the way in the transition \
spectrum: old qwidget ones and those, which can ignore the qwidget part. It's clearly \
transitional but i don't think there is a way to realistically have qobject only ones \
before there is something working in place?</p></pre> </blockquote>
<p>On February 25th, 2015, 5:45 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thinking about it, one way that and almost legacyless way could be done is: \
having in a separate library, tier2 a qobject based thing that has an api similar to \
kcmodule, and doing the qml kcms directly in that. then this class goes in pretty \
similar, except the plugins wouldn't subclass it, but would be used directly to load \
one of those qobject only thinghies. the disadvantage would be that systemsettings, \
kcmshell (and pretty much any app config dialog that loads kcms) would have to \
directly special case for this, so the transition would be more painful.</p></pre> \
</blockquote>
<p>On February 25th, 2015, 6:13 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes \
sense. I think we can combine the two approaches.</p> <ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">New-style QML "KCMs" do not link KCModule directly, but \
rather use the imports you describe.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">A special-sauce KCM does \
the necessary bits to load these new-style KCMs (pretty much what this patch does, \
really)</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That way, we allow legacy-free new-style, but make it \
compatible with everything old-style, QWidget-based KCMs, systemsettings, kcmshell, \
etc.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A new "systemsettings-qml" would have to be \
special-cased in order to also load KCModule/QWidget-based modules, but I don't think \
there's any way around that anyway.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The architecture of System Settings should allow it to host native QML KCMs \
without having to use the KCModule class, assuming the appropriate changes are \
made.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On February 25th, 2015, 5:40 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2015, 5:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this adds a new class called KCModuleQml it loads a \
KPackage with the same plugin name as the kcm, then loads its mainscript qml file \
from it and puts it in a QQuickView used as main widget of the KCM.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It supports two ways of loading the qml: one is in the showevent of the KCM \
qwidget, this is compatible with current Systemsettings and kcmshell. the other way \
is with the mainUi accessor/qproperty. This will make possible for a pure QML version \
of systemsettings (accessing directly mainUi without showing qwidgets)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f3aaf18)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(10862c6)</span></li>
<li>src/kcmoduleqml.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcmoduleqml.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122706/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0807149577253761577==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic