[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: New framework: KXmlRpcClient
From:       David Faure <faure () kde ! org>
Date:       2015-02-25 12:29:03
Message-ID: 3126128.PRQZfLyf3l () asterix
[Download RAW message or body]

On Wednesday 11 February 2015 15:03:06 Aleix Pol wrote:
> On Thu, Jan 8, 2015 at 6:08 PM, Daniel Vrátil <dvratil@redhat.com> \
> wrote:
> > Hi all,
> > 
> > KXmlRpcClient provides a complete XMLRPC client for applications to \
> > use. It's used most notably by DrKonqi to talk to b.k.o. It's the first
> > framework split from kdepimlibs that we feel is ready to be shipped \
> > with KDE Frameworks.
> > 
> > I went through the code, fixed couple minor problems I spotted and \
> > added unit- tests to test the (de)marshaller code properly.
> > 
> > It should be a Tier 3 framework, as it depends on KIO (for HTTP
> > interaction).
> > 
> > I would like to submit the KXmlRpcClient for the standard 2 week review
> > period, and if everything is OK, then move it to Frameworks (so we can
> > finally drop the bundled copy from DrKonqi ;-)).
> > 
> > Cheers,
> > Daniel
> 
> Hi,
> What's the status of this?
> 
> I might be able to help if there's some task to be done.

AFAICS it's all set for being part of KF 5.8.

Ah, except one thing, it has weird version numbering for the .so itself.

Can I apply this?

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 01e6de9..084910b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -18,10 +18,9 @@ include(KDEFrameworkCompilerSettings)
 
 set(KF5_VERSION "5.8.0") # handled by release scripts
 set(KF5_DEP_VERSION "5.7.0") # handled by release scripts
-set(KXMLRPCCLIENT_LIB_VERSION "4.79.0")
 
 add_definitions(-DTRANSLATION_DOMAIN=\"libkxmlrpcclient5\")
-ecm_setup_version(${KXMLRPCCLIENT_LIB_VERSION} VARIABLE_PREFIX \
KXMLRPCCLIENT +ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX \
                KXMLRPCCLIENT
                         VERSION_HEADER \
                "${CMAKE_CURRENT_BINARY_DIR}/kxmlrpcclient_version.h"
                         PACKAGE_VERSION_FILE \
"${CMAKE_CURRENT_BINARY_DIR}/KF5XmlRpcClientConfigVersion.cmake"  SOVERSION \
5


-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread]