'Review Request 122667: Some tools for easily do qml based apps using KPackage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 122667: Some tools for easily do qml based apps using KPackage
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-02-21 18:26:09
Message-ID: 20150221182609.4989.69643 () probe ! kde ! org
[Download RAW message or body]

--===============9070959505309006598==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122667/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.

Repository: kdeclarative

Description
-------

This is still a bit rough but adding it there for early feedback. comes from the fact \
that I would like a standard-ish way for KDE apps to do QML based apps

It adds 3 things:
* KPackage support to QmlObject: the class is done to easily load QML without using \
qquickview, since I want to push loading qml from KPackages, adding kpackage support \
                to this class seems to make sense
* qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both \
the case the root object is a qquickitem or an ApplicationWindow \
qtquickcomponent(that is a window in itself) puts proper window title and icon, sets \
the kaboutdata from the metadata file, binds commandline arguments in the context \
                (kinda feel some other bindings/API could be needed)
* KPackageView: is a qquickview that loads kpackages... seeing that the direction \
from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add \
this tough

Diffs
-----

  src/quickaddons/CMakeLists.txt 8272f1f 
  src/quickaddons/kpackageview.h PRE-CREATION 
  src/quickaddons/kpackageview.cpp PRE-CREATION 
  tests/CMakeLists.txt a8abfaf 
  tests/helloworld/contents/ui/main.qml PRE-CREATION 
  tests/helloworld/metadata.desktop PRE-CREATION 
  CMakeLists.txt 52a698a 
  src/CMakeLists.txt 32da8a5 
  src/kdeclarative/CMakeLists.txt 052b9e2 
  src/kdeclarative/qmlobject.h a0a74d3 
  src/kdeclarative/qmlobject.cpp 00478b4 
  src/qmlpackagelauncher/CMakeLists.txt PRE-CREATION 
  src/qmlpackagelauncher/main.cpp PRE-CREATION 
  src/qmlpackagelauncher/view.h PRE-CREATION 
  src/qmlpackagelauncher/view.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122667/diff/

Testing
-------

Thanks,

Marco Martin

--===============9070959505309006598==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122667/">https://git.reviewboard.kde.org/r/122667/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is still a bit rough but adding it there for \
early feedback. comes from the fact that I would like a standard-ish way for KDE apps \
to do QML based apps</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It adds 3 things: <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> \
KPackage support to QmlObject: the class is done to easily load QML without using \
qquickview, since I want to push loading qml from KPackages, adding kpackage support \
to this class seems to make sense </em> qmlpackagelauncher: tiny tool to launch qml \
apps from qml packages: supports both the case the root object is a qquickitem or an \
ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window \
title and icon, sets the kaboutdata from the metadata file, binds commandline \
                arguments in the context (kinda feel some other bindings/API could be \
                needed)
* KPackageView: is a qquickview that loads kpackages... seeing that the direction \
from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add \
this tough</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/quickaddons/CMakeLists.txt <span style="color: grey">(8272f1f)</span></li>

 <li>src/quickaddons/kpackageview.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/quickaddons/kpackageview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(a8abfaf)</span></li>

 <li>tests/helloworld/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>tests/helloworld/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(52a698a)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(32da8a5)</span></li>

 <li>src/kdeclarative/CMakeLists.txt <span style="color: grey">(052b9e2)</span></li>

 <li>src/kdeclarative/qmlobject.h <span style="color: grey">(a0a74d3)</span></li>

 <li>src/kdeclarative/qmlobject.cpp <span style="color: grey">(00478b4)</span></li>

 <li>src/qmlpackagelauncher/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlpackagelauncher/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlpackagelauncher/view.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlpackagelauncher/view.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122667/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9070959505309006598==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 