'Review Request 122642: an include is not correct'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 122642: an include is not correct
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2015-02-19 18:11:10
Message-ID: 20150219181110.4989.20906 () probe ! kde ! org
[Download RAW message or body]

--===============4770596912723464566==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122642/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kcoreaddons

Description
-------

trying to compile frameworks/kservice/src/services/kserviceaction.cpp
I get:
/usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: \
'kcoreaddons_export.h' file not found fatal error: 'kcoreaddons_export.h' file not \
found#include "kcoreaddons_export.h"

I propose to change it to
#include <kcoreaddons_export.h>

Diffs
-----

  src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 

Diff: https://git.reviewboard.kde.org/r/122642/diff/

Testing
-------

Thanks,

Guy Maurel

--===============4770596912723464566==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122642/">https://git.reviewboard.kde.org/r/122642/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Guy Maurel.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">trying to compile frameworks/kservice/src/services/kserviceaction.cpp I \
                get:
/usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: \
&#39;kcoreaddons_export.h&#39; file not found fatal error: \
&#39;kcoreaddons_export.h&#39; file not found#include \
&quot;kcoreaddons_export.h&quot;

I propose to change it to
#include &lt;kcoreaddons_export.h&gt;</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/plugin/kpluginfactory.h <span style="color: \
grey">(d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122642/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4770596912723464566==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 