'Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2015-02-16 18:29:02
Message-ID: 20150216182902.4989.41162 () probe ! kde ! org
[Download RAW message or body]

--===============3686676654766164387==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 6:29 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and Thiago \
Macieira.

Repository: kconfig

Description
-------

The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.

I propose to use:
    QString plus = QLatin1String("/");
    QString dirPlus;
...
     Q_FOREACH (...) {
        dirPlus = dir;
        dirPlus.append(plus);
        if (path.startsWith(dirPlus)) {

Diffs
-----

  src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509 

Diff: https://git.reviewboard.kde.org/r/122445/diff/

Testing
-------

Thanks,

Guy Maurel

--===============3686676654766164387==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122445/">https://git.reviewboard.kde.org/r/122445/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and \
Thiago Macieira.</div> <div>By Guy Maurel.</div>

<p style="color: grey;"><i>Updated Feb. 16, 2015, 6:29 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The if statements at lines 84, 91 if \
(path.startsWith(dir) + '/') { cannot be correct. The value of (path.startsWith(dir) \
+ '/') is always 47.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I propose to use:  QString plus = \
QLatin1String("/");  QString dirPlus;
...
     Q_FOREACH (...) {
        dirPlus = dir;
        dirPlus.append(plus);
        if (path.startsWith(dirPlus)) {</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kdesktopfile.cpp <span style="color: \
grey">(6381cb30ba9382de492e2d8d4cf1f9e342f1c509)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122445/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3686676654766164387==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 