[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly
From: "David Faure" <faure () kde ! org>
Date: 2015-02-16 17:37:38
Message-ID: 20150216173738.4989.43071 () probe ! kde ! org
[Download RAW message or body]
--===============9154215667352298949==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 3, 2015, 9:33 p.m., David Faure wrote:
> > src/currency.cpp, line 672
> > <https://git.reviewboard.kde.org/r/122183/diff/3/?file=346607#file346607line672>
> >
> > well then we still have a problem if the CurrencyCategory is being deleted before \
> > this job finishes. Can this happen? If so, then the destructor of the \
> > CurrencyCategory[Private] should delete the networkaccessmanager, to make sure \
> > that it can't emit finished later.
>
> Vishesh Handa wrote:
> CurrencyCategory is initialized by a singleton, so meh.
>
> If you want, I can add it, though now I'm having second thoughts about this, and \
> maybe we should be going for the separate thread + blocking approach.
OK then the crash can't happen (no event loop after deletion of singletons), so no \
problem.
> On Feb. 3, 2015, 9:33 p.m., David Faure wrote:
> > src/currency.cpp, line 674
> > <https://git.reviewboard.kde.org/r/122183/diff/3/?file=346607#file346607line674>
> >
> > missing error handling on the open() call [was there before this patch]
>
> Vishesh Handa wrote:
> Was it? I don't see any error handling. Also, I'm not sure what to do in that case.
oops my comment was confusing. I meant: "missing error handling the open() call - \
even though I know that this problem was already there, it wasn't introduced by this \
change".
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122183/#review75337
-----------------------------------------------------------
On Feb. 3, 2015, 12:49 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122183/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:49 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 340819
> https://bugs.kde.org/show_bug.cgi?id=340819
>
>
> Repository: kunitconversion
>
>
> Description
> -------
>
> Currency: Fetch the currency file properly
>
> Properly run an event loop and wait for the file to be fetched.
>
> Also add a test to make sure currency conversion is working.
>
> This patch also contains -
> * https://git.reviewboard.kde.org/r/122182/
> * https://git.reviewboard.kde.org/r/122181/
> * https://git.reviewboard.kde.org/r/122180/
>
> This is because reviewboard refuses to upload only a part of the diff. Please only \
> look at currency.cpp w.r.t the EventLoop.
>
> Diffs
> -----
>
> autotests/convertertest.h 8129a48
> autotests/convertertest.cpp ae4298e
> src/currency.cpp 715233c
>
> Diff: https://git.reviewboard.kde.org/r/122183/diff/
>
>
> Testing
> -------
>
> Test now passes.
>
>
> Thanks,
>
> Vishesh Handa
>
>
--===============9154215667352298949==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122183/">https://git.reviewboard.kde.org/r/122183/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 3rd, 2015, 9:33 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122183/diff/3/?file=346607#file346607line672" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/currency.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Value \
CurrencyCategoryPrivate::convert(const Value &value, const Unit \
&to)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">669</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">reply</span><span \
class="o">-></span><span class="n">bytesAvailable</span><span class="p">()</span> \
<span class="o">></span> <span class="mi">0</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">672</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QObject</span><span class="o">::</span><span \
class="n">connect</span><span class="p">(</span><span class="n">manager</span><span \
class="p">,</span> <span class="o">&</span><span \
class="n">QNetworkAccessManager</span><span class="o">::</span><span \
class="n">finished</span><span class="p">,</span> <span class="p">[</span><span \
class="o">&</span><span class="p">](</span><span \
class="n">QNetworkReply</span><span class="o">*</span> <span \
class="n">reply</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">well \
then we still have a problem if the CurrencyCategory is being deleted before this job \
finishes. Can this happen? If so, then the destructor of the \
CurrencyCategory[Private] should delete the networkaccessmanager, to make sure that \
it can't emit finished later.</p></pre> </blockquote>
<p>On February 16th, 2015, 3:22 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">CurrencyCategory is initialized by a singleton, so meh.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you want, I can add it, though now I'm having second thoughts about \
this, and maybe we should be going for the separate thread + blocking \
approach.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">OK then the crash can't happen (no event loop after deletion of \
singletons), so no problem.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 3rd, 2015, 9:33 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122183/diff/3/?file=346607#file346607line674" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/currency.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Value \
CurrencyCategoryPrivate::convert(const Value &value, const Unit \
&to)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">674</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">cacheFile</span><span class="p">.</span><span \
class="n">open</span><span class="p">(</span><span class="n">QFile</span><span \
class="o">::</span><span class="n">WriteOnly</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">missing error handling on the open() call [was there before this \
patch]</p></pre> </blockquote>
<p>On February 16th, 2015, 3:22 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Was \
it? I don't see any error handling. Also, I'm not sure what to do in that \
case.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">oops my comment was confusing. I meant: "missing error handling the open() \
call - even though I know that this problem was already there, it wasn't introduced \
by this change".</p></pre> <br />
<p>- David</p>
<br />
<p>On February 3rd, 2015, 12:49 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 12:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=340819">340819</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kunitconversion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currency: Fetch the currency file properly</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Properly run an event loop and wait for the file to be fetched.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also add a test to make sure currency conversion is working.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch also contains - <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> \
https://git.reviewboard.kde.org/r/122182/ </em> \
https://git.reviewboard.kde.org/r/122181/
* https://git.reviewboard.kde.org/r/122180/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is because reviewboard refuses to upload only a \
part of the diff. Please only look at currency.cpp w.r.t the EventLoop.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Test now passes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/convertertest.h <span style="color: grey">(8129a48)</span></li>
<li>autotests/convertertest.cpp <span style="color: grey">(ae4298e)</span></li>
<li>src/currency.cpp <span style="color: grey">(715233c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122183/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9154215667352298949==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic