'Re: Review Request 122177: some minor fixes for windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122177: some minor fixes for windows
From:       "Allen Winter" <winter () kde ! org>
Date:       2015-01-21 22:53:26
Message-ID: 20150121225326.32443.73577 () probe ! kde ! org
[Download RAW message or body]

--===============7209711977527520218==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122177/#review74509
-----------------------------------------------------------

Ship it!

Ship It!

- Allen Winter

On Jan. 21, 2015, 10:39 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122177/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 10:39 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> some minor fixes for windows
> 
> 
> Diffs
> -----
> 
> src/runtime/CMakeLists.txt a8fbfa1612a86f7371bf56926ec46fe14422a73a 
> src/runtime/main.cpp f9cf9b353f00f1f68906d97f61cea5314a3663e4 
> 
> Diff: https://git.reviewboard.kde.org/r/122177/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2013
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
> 

--===============7209711977527520218==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122177/">https://git.reviewboard.kde.org/r/122177/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Allen Winter</p>

<br />
<p>On January 21st, 2015, 10:39 p.m. UTC, Patrick Spendrin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Patrick Spendrin.</div>

<p style="color: grey;"><i>Updated Jan. 21, 2015, 10:39 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">some minor fixes for windows</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">windows msvc 2013</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/runtime/CMakeLists.txt <span style="color: \
grey">(a8fbfa1612a86f7371bf56926ec46fe14422a73a)</span></li>

 <li>src/runtime/main.cpp <span style="color: \
grey">(f9cf9b353f00f1f68906d97f61cea5314a3663e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122177/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7209711977527520218==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 