'Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2015-01-18 12:43:24
Message-ID: 20150118124324.28748.32748 () probe ! kde ! org
[Download RAW message or body]

--===============5920804666941785842==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122007/
-----------------------------------------------------------

(Updated Jan. 18, 2015, 12:43 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, David Faure and Thiago Macieira.

Repository: kio

Description
-------

This pull request fixes a long standing issue in KTcpSocket where member functions \
"negotiatedSslVersion" and "negotiatedSslVersionName" returned the requested protocol \
instead of the actual negotiated one because QSslSocket did provide a means of \
accessing the actual negotiated protocol. Since this has been addressed in Qt 5.4, \
the problem should be fixed in KTcpSocket as well. Additionally the patch also adds \
support for Tlsv1_1 and TlsV1_2 protocols.

Diffs
-----

  src/core/ktcpsocket.h d59b180 
  src/core/ktcpsocket.cpp f223986 
  src/core/tcpslavebase.cpp e62e72a 

Diff: https://git.reviewboard.kde.org/r/122007/diff/

Testing
-------

Thanks,

Dawit Alemayehu

--===============5920804666941785842==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122007/">https://git.reviewboard.kde.org/r/122007/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Thiago Macieira.</div>
<div>By Dawit Alemayehu.</div>

<p style="color: grey;"><i>Updated Jan. 18, 2015, 12:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This pull request fixes a long standing issue in \
KTcpSocket where member functions "negotiatedSslVersion" and \
"negotiatedSslVersionName" returned the requested protocol instead of the actual \
negotiated one because QSslSocket did provide a means of accessing the actual \
negotiated protocol. Since this has been addressed in Qt 5.4, the problem should be \
fixed in KTcpSocket as well. Additionally the patch also adds support for Tlsv1_1 and \
TlsV1_2 protocols.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/ktcpsocket.h <span style="color: grey">(d59b180)</span></li>

 <li>src/core/ktcpsocket.cpp <span style="color: grey">(f223986)</span></li>

 <li>src/core/tcpslavebase.cpp <span style="color: grey">(e62e72a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122007/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5920804666941785842==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 