[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Move thumbnail kioslave and thumbcreator service type to kio?
From:       David Faure <faure () kde ! org>
Date:       2015-01-18 10:01:08
Message-ID: 3990675.8HzLPlXWy7 () asterix
[Download RAW message or body]

On Sunday 18 January 2015 11:53:58 Bhushan Shah wrote:
> Hello!
> 
> At moment thumbnail kioslave and thumcreator servicetype is provided
> by kio-extras repo. However KImageFilePreview uses thumbcreator
> service type, which results in non functioning KIMageFIlePreview with
> error/warning,
> 
> KServiceTypeTrader: serviceType "ThumbCreator" not found
> 
> if kio-extras is not installed, so kio-extras becomes hidden dep for kio..
> 
> So any thoughts on moving thumbnail kioslave and thumbcreator service
> type to kio?

The servicetype: yes, for sure, it should be there.

The kioslave: on one hand, we can't have all kioslaves in kio; on the other 
hand, this one indeed has specific API in KIO (PreviewJob), which doesn't work 
if kio_thumbnail isn't there. Given that kio_thumbnail has no additional 
required dependency (apart from libjpeg), I am OK with it moving to the KIO 
framework.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]