[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.
From: "Elias Probst" <mail () eliasprobst ! eu>
Date: 2015-01-09 17:07:54
Message-ID: 20150109170754.15695.75062 () probe ! kde ! org
[Download RAW message or body]
--===============0341655717049606371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121953/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 5:07 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kservice
Description
-------
Add filename to KPluginInfo::property() deprecation notice.
Diffs
-----
src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b
Diff: https://git.reviewboard.kde.org/r/121953/diff/
Testing
-------
The deprecation notice for `KPluginInfo::property()` includes now the filename of the \
originating file, making it easier to update it.
```
Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use \
KPluginInfo::pluginName() in \
"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so" instead. \
Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use \
KPluginInfo::pluginName() in \
"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so" instead. Calling \
KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use \
KPluginInfo::pluginName() in \
"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so" instead. ```
Thanks,
Elias Probst
--===============0341655717049606371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121953/">https://git.reviewboard.kde.org/r/121953/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 5:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add filename to KPluginInfo::property() deprecation \
notice.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The deprecation notice for <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">KPluginInfo::property()</code> includes now the filename of \
the originating file, making it easier to update it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Calling \
KPluginInfo<span style="color: #666666">::</span>property(<span style="color: \
#BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use \
KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: \
#BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so"</span> \
instead. Calling KPluginInfo<span style="color: #666666">::</span>property(<span \
style="color: #BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use \
KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: \
#BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so"</span> \
instead. Calling KPluginInfo<span style="color: #666666">::</span>property(<span \
style="color: #BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use \
KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: \
#BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so"</span> \
instead. </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kplugininfo.cpp <span style="color: \
grey">(98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121953/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0341655717049606371==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic