[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
From: "Elias Probst" <mail () eliasprobst ! eu>
Date: 2015-01-09 16:01:50
Message-ID: 20150109160150.28638.51454 () probe ! kde ! org
[Download RAW message or body]
--===============7901772245315685990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121949/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 4:01 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kservice
Description
-------
Until now, there was no way to tell from the logged message where it was originating \
from. This change makes it easier to find the originating application.
Diffs
-----
src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa66667961d68b16
Diff: https://git.reviewboard.kde.org/r/121949/diff/
Testing
-------
Getting now messages logged which look like this:
```
Constructing a KPluginInfo object from old style JSON. Please use \
kcoreaddons_desktop_to_json() for "Kate Session Applet" instead of \
kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from \
old style JSON. Please use kcoreaddons_desktop_to_json() for "DataEngine for \
Kimpanel" instead of kservice_desktop_to_json() in your CMake code. Constructing a \
KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for \
"Konsole Profiles" instead of kservice_desktop_to_json() in your CMake code. ```
This makes it definitely far easier to update the affected applications.
Thanks,
Elias Probst
--===============7901772245315685990==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121949/">https://git.reviewboard.kde.org/r/121949/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 4:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Until now, there was no way to tell from the logged \
message where it was originating from. This change makes it easier to find the \
originating application.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Getting now messages logged which look like this:</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">Constructing a KPluginInfo object from old \
style JSON. Please use kcoreaddons_desktop_to_json() <span style="color: #008000; \
font-weight: bold">for</span> <span style="color: #BA2121">"Kate Session \
Applet"</span> instead of kservice_desktop_to_json() in your CMake code. \
Constructing a KPluginInfo object from old style JSON. Please use \
kcoreaddons_desktop_to_json() <span style="color: #008000; font-weight: \
bold">for</span> <span style="color: #BA2121">"DataEngine for \
Kimpanel"</span> instead of kservice_desktop_to_json() in your CMake code. \
Constructing a KPluginInfo object from old style JSON. Please use \
kcoreaddons_desktop_to_json() <span style="color: #008000; font-weight: \
bold">for</span> <span style="color: #BA2121">"Konsole Profiles"</span> \
instead of kservice_desktop_to_json() in your CMake code. </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This makes it definitely far easier to update the \
affected applications.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kplugininfo.cpp <span style="color: \
grey">(aa5d26386eb17a7e552b29c8fa66667961d68b16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121949/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7901772245315685990==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic