[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121922: support stringlists as properties
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-01-08 16:19:52
Message-ID: 20150108161952.15695.26410 () probe ! kde ! org
[Download RAW message or body]
--===============5030348692490466193==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/#review73512
-----------------------------------------------------------
I'm not convinced. Can't you use .json directly like we did in KDevelop? This solved \
the issue for us. desktop2json is pretty brittle and should become deprecated, I \
think.
If you want to continue down this route, please add unit tests.
src/services/kplugininfo.cpp
<https://git.reviewboard.kde.org/r/121922/#comment51157>
',' or ';'.
but, shouldn't it be only one or the other? isn't the .desktop file specification \
telling you which one it is? or is this all KDE custom? In KDevelop at least, the \
format always was "foo, bar, ...". Note the extra whitespace, which you are not \
trimming.
- Milian Wolff
On Jan. 8, 2015, 3:34 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 3:34 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> if a property is defined as a StringList in a servicetype, return it as an actual \
> stringlist upon KPluginInfo::property() instead of a string (with commas to separe \
> the entries), having the same behavior of KService
> This is necessary to have the same behavior between the old \
> KServiceTypeTrader::query() and
> KPluginTrader::applyConstraints
>
> because without list properties, all queries with the "in" keyword wouldn't work, \
> such as "org.kde.plasma.time in [X-Plasma-Provides]"
>
>
> Diffs
> -----
>
> src/services/kplugininfo.cpp aa5d263
>
> Diff: https://git.reviewboard.kde.org/r/121922/diff/
>
>
> Testing
> -------
>
> queries on list properties with "in" do work now
>
>
> Thanks,
>
> Marco Martin
>
>
--===============5030348692490466193==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121922/">https://git.reviewboard.kde.org/r/121922/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not convinced. Can't you use .json directly like we did in KDevelop? This solved the \
issue for us. desktop2json is pretty brittle and should become deprecated, I \
think.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you want to continue down this route, please add \
unit tests.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121922/diff/2/?file=339120#file339120line533" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/services/kplugininfo.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QVariant KPluginInfo::property(const QString &key) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">533</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//special case if we want a stringlist: split values by ',' and \
construct the list</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">',' \
or ';'.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">but, shouldn't it be only one or the other? isn't the \
.desktop file specification telling you which one it is? or is this all KDE custom? \
In KDevelop at least, the format always was "foo, bar, ...". Note the extra \
whitespace, which you are not trimming.</p></pre> </div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 8th, 2015, 3:34 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2015, 3:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if a property is defined as a StringList in a \
servicetype, return it as an actual stringlist upon KPluginInfo::property() instead \
of a string (with commas to separe the entries), having the same behavior of \
KService</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is necessary to have the same behavior between \
the old KServiceTypeTrader::query() and
KPluginTrader::applyConstraints</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">because without list properties, all queries with the \
"in" keyword wouldn't work, such as "org.kde.plasma.time in \
[X-Plasma-Provides]"</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">queries on list properties with "in" do work \
now</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kplugininfo.cpp <span style="color: grey">(aa5d263)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121922/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5030348692490466193==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic