'Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows im'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 121861: Remove obsolate class KFileSystemWatcher,  which is handled by Windows im
From:       "David Faure" <faure () kde ! org>
Date:       2015-01-05 21:37:24
Message-ID: 20150105213724.15695.76041 () probe ! kde ! org
[Download RAW message or body]

--===============1333570376402045757==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121861/#review73207
-----------------------------------------------------------

Ship it!

Ah cool, I didn't know the Qt5 implementation of QFSW solved this. Nice.

- David Faure

On Jan. 5, 2015, 6:43 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121861/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Remove obsolate class KFileSystemWatcher, which is handled by Windows \
> implementation of Qt5 QFileSystemWatcher. 
> 
> Diffs
> -----
> 
> src/lib/CMakeLists.txt b2b46b164097f2394957f99ec4fb97b52f2bbc96 
> src/lib/io/kdirwatch.cpp 71f1892180b51cf65426696b4ffe918a02debba0 
> src/lib/io/kdirwatch_p.h 12839fdf4af5312eae3a636cec73f9dd2a41057d 
> src/lib/io/kdirwatch_win.cpp 846e91ab1c932fbe1117ca6e3de3008f7f3a2130 
> 
> Diff: https://git.reviewboard.kde.org/r/121861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
> 

--===============1333570376402045757==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121861/">https://git.reviewboard.kde.org/r/121861/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah \
cool, I didn't know the Qt5 implementation of QFSW solved this. Nice.</p></pre>  <br \
/>

<p>- David Faure</p>

<br />
<p>On January 5th, 2015, 6:43 p.m. UTC, Ralf Habacker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Ralf Habacker.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2015, 6:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove obsolate class KFileSystemWatcher, which is handled by Windows \
implementation of Qt5 QFileSystemWatcher.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/CMakeLists.txt <span style="color: \
grey">(b2b46b164097f2394957f99ec4fb97b52f2bbc96)</span></li>

 <li>src/lib/io/kdirwatch.cpp <span style="color: \
grey">(71f1892180b51cf65426696b4ffe918a02debba0)</span></li>

 <li>src/lib/io/kdirwatch_p.h <span style="color: \
grey">(12839fdf4af5312eae3a636cec73f9dd2a41057d)</span></li>

 <li>src/lib/io/kdirwatch_win.cpp <span style="color: \
grey">(846e91ab1c932fbe1117ca6e3de3008f7f3a2130)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121861/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1333570376402045757==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 