'Re: Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.
From:       "David Faure" <faure () kde ! org>
Date:       2015-01-05 19:42:39
Message-ID: 20150105194239.31735.45051 () probe ! kde ! org
[Download RAW message or body]

--===============0579811510311439077==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121865/#review73199
-----------------------------------------------------------

Ship it!

the commit log is a bit confusing though. Did you mean instead of instead of instead? \
Haha LOL let me add some double quotes to that... Did you mean "instead of" instead \
of "instead"? :-)

- David Faure

On Jan. 5, 2015, 6:42 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121865/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 6:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Fix cross compile error using Windows.h instead correctly windows.h.
> 
> 
> Diffs
> -----
> 
> src/karchive.cpp 4459d351caf17f9feea1d13d3870f35f12ba27cb 
> 
> Diff: https://git.reviewboard.kde.org/r/121865/diff/
> 
> 
> Testing
> -------
> 
> compiled package at \
> https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF5/mingw32-karchive
>  
> 
> Thanks,
> 
> Ralf Habacker
> 
> 

--===============0579811510311439077==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121865/">https://git.reviewboard.kde.org/r/121865/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
commit log is a bit confusing though. Did you mean instead of instead of instead? \
Haha LOL let me add some double quotes to that... Did you mean "instead of" instead \
of "instead"? :-)</p></pre>  <br />

<p>- David Faure</p>

<br />
<p>On January 5th, 2015, 6:42 p.m. UTC, Ralf Habacker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Ralf Habacker.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2015, 6:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix cross compile error using Windows.h instead \
correctly windows.h.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiled package at \
https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF5/mingw32-karchive</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/karchive.cpp <span style="color: \
grey">(4459d351caf17f9feea1d13d3870f35f12ba27cb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121865/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0579811510311439077==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 