[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121595: Always return absolute paths in Kdelibs4Migration
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-12-19 11:58:07
Message-ID: 20141219115807.31946.92119 () probe ! kde ! org
[Download RAW message or body]
--===============0114643613516058999==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121595/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 11:58 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Marco Martin.
Repository: kcoreaddons
Description
-------
KDELibs4Migration returns an absolute path in the case that .kde or
.kde4 exist.
If that folder does not exist and we fall back to KDE4_DEFAULT_HOME we
also want an absolute path, which currently is not happening.
This fixes the kde4breeze script which is launched from kconf_update
writing a kdeglobals file in the wrong directory.
Diffs
-----
src/lib/util/kdelibs4migration.cpp 4a6ba0d
Diff: https://git.reviewboard.kde.org/r/121595/diff/
Testing
-------
Thanks,
David Edmundson
--===============0114643613516058999==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121595/">https://git.reviewboard.kde.org/r/121595/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Marco Martin.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2014, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KDELibs4Migration returns an absolute path in the case \
that .kde or
.kde4 exist.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If that folder does not exist and we fall back to \
KDE4_DEFAULT_HOME we also want an absolute path, which currently is not \
happening.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes the kde4breeze script which is launched \
from kconf_update writing a kdeglobals file in the wrong directory.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/util/kdelibs4migration.cpp <span style="color: \
grey">(4a6ba0d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121595/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0114643613516058999==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic