[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121448: Introduce ECMAddAppIcon.
From: Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date: 2014-12-12 17:14:38
Message-ID: 20141212171438.4027.14643 () probe ! kde ! org
[Download RAW message or body]
--===============3244593077415925014==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
On Dic. 11, 2014, 1:02 p.m., Ralf Habacker wrote:
> > Regarding patterns, why not just using a list of the icons we need? \
> > patterns+cmake have weird effects... Would it be possible to include a test? It's \
> > reasonably easy to create ecm tests nowadays and very useful afterwards. You'll \
> > see some examples in the repository.
> > By the way, thanks for looking into this, really needed!
>
> Ralf Habacker wrote:
> > Regarding patterns
>
> pattern has be introduced in kde4 times because applications provides many \
> different combinations of resolutions, which has otherwise to be maintained by \
> hand. You cannot run simply "ls hi*-app-<app-name>.png" and paste the result into \
> this macro because the windows icon format supports only a subset of resolutions. \
> Umbrello for example returns
> hi128-app-umbrello.png hi16-app-umbrello.png hi22-app-umbrello.png \
> hi32-app-umbrello.png hi48-app-umbrello.png hi64-app-umbrello.png
> from which you need to exclude 'hi22-app-umbrello.png' by hand. The script \
> maintains this for you by using the following form:
> ecm_app_app_icon(myapp_SRCS "pics/cr*-myapp.png")
>
> single files are also possible
>
> ecm_app_app_icon(myapp_SRCS "pics/cr16-myapp.png;pics/cr32-myapp.png")
>
> > Would it be possible to include a test?
>
> You mean to create a simple test app and CMakeLists.txt including this script ?
> sure, on windows this would require to have the png2ico tool installed for example \
> from the kdewin-tool binary package or build from kdewin repo
> > You'll see some examples in the repository.
>
> which repo are your refering ? extra-cmake-modules do not contain any example
As far as I know, the Windows .ico format supports arbitrary resolutions. The \
limitations come from png2ico.
- Nicolás
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/#review71815
-----------------------------------------------------------
On Dic. 12, 2014, 10:34 a.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121448/
> -----------------------------------------------------------
>
> (Updated Dic. 12, 2014, 10:34 a.m.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
> supports platform specific application icon for Windows and Mac OSX.
>
> On Windows this function depends on the external tool png2ico, which is
> provided by the kdewin-tools binary package. Sources are available at
> https://projects.kde.org/projects/kdesupport/kdewin.
>
>
> Diffs
> -----
>
> modules/ECMAddAppIcon.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121448/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake
>
>
> Thanks,
>
> Ralf Habacker
>
>
--===============3244593077415925014==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121448/">https://git.reviewboard.kde.org/r/121448/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Diciembre 11th, 2014, 1:02 p.m. ART, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regarding patterns, why not just using a list of the \
icons we need? patterns+cmake have weird effects... Would it be possible to include a \
test? It's reasonably easy to create ecm tests nowadays and very useful afterwards. \
You'll see some examples in the repository.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">By the way, thanks for \
looking into this, really needed!</p></pre> </blockquote>
<p>On Diciembre 12th, 2014, 7:29 a.m. ART, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Regarding patterns</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">pattern has be introduced in kde4 times because \
applications provides many different combinations of resolutions, which has otherwise \
to be maintained by hand. You cannot run simply "ls hi*-app-<app-name>.png" \
and paste the result into this macro because the windows icon format supports only a \
subset of resolutions. Umbrello for example returns </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">hi128-app-umbrello.png hi16-app-umbrello.png hi22-app-umbrello.png \
hi32-app-umbrello.png hi48-app-umbrello.png hi64-app-umbrello.png </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">from which you need to exclude 'hi22-app-umbrello.png' by hand. The script \
maintains this for you by using the following form: </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ecm_app_app_icon(myapp_SRCS "pics/cr*-myapp.png")</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">single files are also possible</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ecm_app_app_icon(myapp_SRCS "pics/cr16-myapp.png;pics/cr32-myapp.png")</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Would it be possible to include a test? </p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You mean to create a simple test app and \
CMakeLists.txt including this script ? sure, on windows this would require to have \
the png2ico tool installed for example from the kdewin-tool binary package or build \
from kdewin repo</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You'll see some examples in the repository.</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">which repo are your refering ? extra-cmake-modules do \
not contain any example</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
far as I know, the Windows .ico format supports arbitrary resolutions. The \
limitations come from png2ico.</p></pre> <br />
<p>- Nicolás</p>
<br />
<p>On Diciembre 12th, 2014, 10:34 a.m. ART, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Dic. 12, 2014, 10:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This module, which has been migrated from the related \
KDE4 macto kde4_app_app_icon, supports platform specific application icon for Windows \
and Mac OSX.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Windows this function depends on the external tool \
png2ico, which is provided by the kdewin-tools binary package. Sources are available \
at https://projects.kde.org/projects/kdesupport/kdewin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddAppIcon.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121448/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake">ECMAddAppIcon.cmake</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3244593077415925014==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic