[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion
From:       Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date:       2014-12-09 2:37:44
Message-ID: CANPC-tv0vExo4=0E5VpO6H14HYBegM_DHwigjiAzX09pSA7gbQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> https://git.reviewboard.kde.org/r/121094/

This change fails to compile on Windows, because the unit test has
ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons
library which obviously defines the same function. In addition,
ktexttohtml.h in this context is declaring the function as
__declspec(dllimport), so it expects them to find the function in a linked
library. All this causes a multiple definition error when linking the unit
test.

I see it's being done this way in order to test the private API, but I'm
not sure how to fix it.

Is anyone else testing non-exported API in KF5?

-- 
Nicolás

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra">&gt; <a \
href="https://git.reviewboard.kde.org/r/121094/">https://git.reviewboard.kde.org/r/121094/</a><br><br></div><div \
class="gmail_extra">This change fails to compile on Windows, because the unit test \
has ktexttohtml.cpp as a source file *and* it&#39;s linking to the kcoreaddons \
library which obviously defines the same function. In addition, ktexttohtml.h in this \
context is declaring the function as __declspec(dllimport), so it expects them to \
find the function in a linked library. All this causes a multiple definition error \
when linking the unit test.<br><br></div><div class="gmail_extra">I see it&#39;s \
being done this way in order to test the private API, but I&#39;m not sure how to fix \
it.<br><br>Is anyone else testing non-exported API in KF5?<br></div><div \
class="gmail_extra"><br>-- <br><div class="gmail_signature">Nicolás</div> \
</div></div>



_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread]