[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121372: Differeniate between bookmarks for documents and the web
From: "Matthew Dawson" <matthew () mjdsystems ! ca>
Date: 2014-12-06 20:49:35
Message-ID: 20141206204935.22787.51168 () probe ! kde ! org
[Download RAW message or body]
--===============7875760825152645103==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121372/
-----------------------------------------------------------
(Updated Dec. 6, 2014, 3:49 p.m.)
Review request for KDE Frameworks, Localization and Translation (l10n) and Matthew \
Dawson.
Changes
-------
Copy+paste error on bug number.
Bugs: 341279
https://bugs.kde.org/show_bug.cgi?id=341279
Repository: kconfig
Description
-------
As requested in bug #1164383, this adds a new standard shortcut
for adding bookmarks for web pages.
BUG: 1164383
I'm not sure if this is the best approach. If this is accpted, I'll commit a similar \
change into KConfigWidgets.
Diffs
-----
src/gui/kstandardshortcut.h 5bb07fb9f060b0d5950aed251da985ce3aa46661
src/gui/kstandardshortcut.cpp 84007374c2836c1d61cb9b9361bd4217aa4ddc32
Diff: https://git.reviewboard.kde.org/r/121372/diff/
Testing
-------
Compiles, verified context extracted properly into pot file.
Thanks,
Matthew Dawson
--===============7875760825152645103==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121372/">https://git.reviewboard.kde.org/r/121372/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n) and \
Matthew Dawson.</div> <div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2014, 3:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Copy+paste error on bug number.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=341279">341279</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As requested in bug #1164383, this adds a new standard \
shortcut for adding bookmarks for web pages.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 1164383</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure if this is \
the best approach. If this is accpted, I'll commit a similar change into \
KConfigWidgets.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, verified context extracted properly into pot \
file.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/kstandardshortcut.h <span style="color: \
grey">(5bb07fb9f060b0d5950aed251da985ce3aa46661)</span></li>
<li>src/gui/kstandardshortcut.cpp <span style="color: \
grey">(84007374c2836c1d61cb9b9361bd4217aa4ddc32)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121372/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7875760825152645103==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic