[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-12-05 9:46:01
Message-ID: 20141205094601.22786.92750 () probe ! kde ! org
[Download RAW message or body]
--===============4461886862055652099==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote:
> > After some discussion with the SDK and Book groups in the sprint, I think we should move this into \
> > the kde:kwidgetsaddons repository, in an examples subdirectory.
>
> Laurent Navet wrote:
> do you want me to move this from kdeexamples to kwidgetsaddons ?
>
> Christoph Feck wrote:
> While it indeed makes sense to showcase the features of a framework inside that framework, here I see \
> the problem that the code currently depends on other frameworks.
> So either we showcase multiple frameworks, and have a separate examples repository, or we showcase a \
> single framework, and make sure the examples do not drag in other frameworks.
> Christoph Feck wrote:
> Has a decision been made to strip it down to Qt-only dependencies (and KWidgetAddons of course :) for \
> adding it to KWidgetAddons, or ship it in a separate repository, where we can showcase it together with \
> the other useful KF5 features, such as translations, kconfig etc.?
> Dominik Haumann wrote:
> As someone who worked on KMessageWidget quite a lot, I'd be in favour of having this demo app in an \
> examples directory, as I think it makes sense to keep the code close together.
> Laurent Navet wrote:
> up !
Laurent, the example still uses unrelated frameworks, see my comments above.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review64357
-----------------------------------------------------------
On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 9:33 a.m.)
>
>
> Review request for KDE Examples, KDE Frameworks and Sune Vuorela.
>
>
> Repository: kdeexamples
>
>
> Description
> -------
>
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
>
> Comments appreciated,
>
>
> Diffs
> -----
>
> kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac
> kdeui/kmessagewidgetdemo/main.cpp d3a5bf0
> kdeui/kmessagewidgetdemo/window.h d3a67c8
> kdeui/kmessagewidgetdemo/window.cpp 9786da6
>
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
>
>
> Testing
> -------
>
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.
>
>
> Thanks,
>
> Laurent Navet
>
>
--===============4461886862055652099==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114933/">https://git.reviewboard.kde.org/r/114933/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2014, 9:33 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After some discussion with the SDK and Book groups in the sprint, I think \
we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory.</p></pre> \
</blockquote>
<p>On August 12th, 2014, 5:47 p.m. UTC, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">do you want me to move this from kdeexamples to kwidgetsaddons ?</p></pre> \
</blockquote>
<p>On August 12th, 2014, 7:56 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While it indeed makes sense to showcase the features of a framework inside \
that framework, here I see the problem that the code currently depends on other frameworks.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So either \
we showcase multiple frameworks, and have a separate examples repository, or we showcase a single \
framework, and make sure the examples do not drag in other frameworks.</p></pre> </blockquote>
<p>On September 18th, 2014, 9:29 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Has a decision been made to strip it down to Qt-only dependencies (and \
KWidgetAddons of course :) for adding it to KWidgetAddons, or ship it in a separate repository, where we \
can showcase it together with the other useful KF5 features, such as translations, kconfig \
etc.?</p></pre> </blockquote>
<p>On September 19th, 2014, 10:29 a.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As someone who worked on KMessageWidget quite a lot, I'd be in favour of \
having this demo app in an examples directory, as I think it makes sense to keep the code close \
together.</p></pre> </blockquote>
<p>On December 4th, 2014, 10:20 p.m. UTC, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">up !</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Laurent, the example still uses unrelated frameworks, see my comments \
above.</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On August 12th, 2014, 9:33 a.m. UTC, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Examples, KDE Frameworks and Sune Vuorela.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2014, 9:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is part of Google Code-IN Contest. As \
I'm no more student, I've waited for the end of the contest to work on it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Comments \
appreciated,</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Regression on KTextedit::setClickMessage(), \
as it don't exist in QTextEdit I've commented the line.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kmessagewidgetdemo/CMakeLists.txt <span style="color: grey">(12ef4ac)</span></li>
<li>kdeui/kmessagewidgetdemo/main.cpp <span style="color: grey">(d3a5bf0)</span></li>
<li>kdeui/kmessagewidgetdemo/window.h <span style="color: grey">(d3a67c8)</span></li>
<li>kdeui/kmessagewidgetdemo/window.cpp <span style="color: grey">(9786da6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114933/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4461886862055652099==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic