'Re: Review Request 120969: Fix build on OSX due to missing XDR functions.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120969: Fix build on OSX due to missing XDR functions.
From:       "Mathias Tillman" <master.homer () gmail ! com>
Date:       2014-11-21 16:40:56
Message-ID: 20141121164056.22978.7383 () probe ! kde ! org
[Download RAW message or body]

--===============4525875364822604860==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120969/
-----------------------------------------------------------

(Updated Nov. 21, 2014, 4:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.

Repository: kio-extras

Description
-------

Due to some missing XDR functions on OSX (used to decode unsigned long long), it \
failed to compile. This fixes that by doing some checks for the existence of the \
64-bit datatype functions (for some reason XDR have 5 different functions that do the \
same thing). This patch also merges the mount3 rpc code with the nfs3 code as well as \
remove the unused rpc mount2 code. 

Diffs
-----

  nfs/rpc_mnt3.h cba4ff656a3d524f39cb7f607b8b4b331b41a0c5 
  nfs/rpc_mnt2_xdr.c b380f4f93853ba54112a68ddf851f8f04b251312 
  nfs/rpc_mnt2.x 4aaf97de9ade2655cd48ae460ba24ee322b57183 
  nfs/nfsv3.cpp 368a61febc778688507ffb3954caaf69fc18d371 
  nfs/rpc_nfs2_prot.x cd21123c7b57040d97245f22038153945abe88ee 
  nfs/rpc_nfs2_prot.h 62ab3056a51cc0e89536081c9d5741ff136dc804 
  nfs/rpc_nfs3_prot_xdr.c 57f4a8546ae697f41f98efb24c01b6de739d380f 
  nfs/rpc_nfs3_prot.x fba417c8cd6edb955e018a89dd38942f1e788c69 
  nfs/rpc_nfs3_prot.h 76b2f5becef9cbdc9fd3db08c540c065a43a89a6 
  nfs/rpc_nfs2_prot_xdr.c fb63b8ec2329730ef55c8f068e8abf47e865173b 
  nfs/rpc_mnt3_xdr.c 2016e688770e3753affe20923a8515f2427c5447 
  nfs/rpc_mnt2.h ed21256c4754ce861ff1f5ea5ddc4ca224a7da7e 
  nfs/kio_nfs.h 9943daf670e665121ea51419ea77599ec4d8d4f5 
  nfs/CMakeLists.txt 2ed2186e113dad9e9c178cbac680d7c96dff789a 

Diff: https://git.reviewboard.kde.org/r/120969/diff/

Testing
-------

I haven't personally tried to compile it on OSX, but Marko Käning (the one who \
reported it, https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg19770.html) \
confirmed that it's now compiling fine on OSX. 

Thanks,

Mathias Tillman

--===============4525875364822604860==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120969/">https://git.reviewboard.kde.org/r/120969/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Mathias Tillman.</div>

<p style="color: grey;"><i>Updated Nov. 21, 2014, 4:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Due to some missing XDR functions on OSX (used to \
decode unsigned long long), it failed to compile. This fixes that by doing some \
checks for the existence of the 64-bit datatype functions (for some reason XDR have 5 \
different functions that do the same thing). This patch also merges the mount3 rpc \
code with the nfs3 code as well as remove the unused rpc mount2 code. </p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I haven't personally tried to compile it on OSX, but \
Marko Käning (the one who reported it, \
https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg19770.html) confirmed \
that it's now compiling fine on OSX. </p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>nfs/rpc_mnt3.h <span style="color: \
grey">(cba4ff656a3d524f39cb7f607b8b4b331b41a0c5)</span></li>

 <li>nfs/rpc_mnt2_xdr.c <span style="color: \
grey">(b380f4f93853ba54112a68ddf851f8f04b251312)</span></li>

 <li>nfs/rpc_mnt2.x <span style="color: \
grey">(4aaf97de9ade2655cd48ae460ba24ee322b57183)</span></li>

 <li>nfs/nfsv3.cpp <span style="color: \
grey">(368a61febc778688507ffb3954caaf69fc18d371)</span></li>

 <li>nfs/rpc_nfs2_prot.x <span style="color: \
grey">(cd21123c7b57040d97245f22038153945abe88ee)</span></li>

 <li>nfs/rpc_nfs2_prot.h <span style="color: \
grey">(62ab3056a51cc0e89536081c9d5741ff136dc804)</span></li>

 <li>nfs/rpc_nfs3_prot_xdr.c <span style="color: \
grey">(57f4a8546ae697f41f98efb24c01b6de739d380f)</span></li>

 <li>nfs/rpc_nfs3_prot.x <span style="color: \
grey">(fba417c8cd6edb955e018a89dd38942f1e788c69)</span></li>

 <li>nfs/rpc_nfs3_prot.h <span style="color: \
grey">(76b2f5becef9cbdc9fd3db08c540c065a43a89a6)</span></li>

 <li>nfs/rpc_nfs2_prot_xdr.c <span style="color: \
grey">(fb63b8ec2329730ef55c8f068e8abf47e865173b)</span></li>

 <li>nfs/rpc_mnt3_xdr.c <span style="color: \
grey">(2016e688770e3753affe20923a8515f2427c5447)</span></li>

 <li>nfs/rpc_mnt2.h <span style="color: \
grey">(ed21256c4754ce861ff1f5ea5ddc4ca224a7da7e)</span></li>

 <li>nfs/kio_nfs.h <span style="color: \
grey">(9943daf670e665121ea51419ea77599ec4d8d4f5)</span></li>

 <li>nfs/CMakeLists.txt <span style="color: \
grey">(2ed2186e113dad9e9c178cbac680d7c96dff789a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120969/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4525875364822604860==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 