[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121143: add translationDomain for katepartui.rc
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-11-16 20:33:56
Message-ID: 20141116203356.22978.86737 () probe ! kde ! org
[Download RAW message or body]
--===============3358687939675983750==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121143/#review70477
-----------------------------------------------------------
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Nov. 16, 2014, 8:27 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121143/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2014, 8:27 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Translation messages in src/data/katepartui.rc are extracted into the catalog \
> ktexteditor5
> Without the definition of translationDomain in katepartui the queries for the \
> translation of these strings in katepartui.rc are performed with the application \
> translationDomain (e.g. "kate" or "kwrite") and the strings are untranslated in \
> the GUI.
> With this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ \
> the queries for translation of these strings in katepartui.rc are performed with \
> the translationDomain "ktexteditor5" and e.g. the menu items in kate/kwrite are \
> fully translated now.
>
> Diffs
> -----
>
> src/data/katepartui.rc 6673b64
>
> Diff: https://git.reviewboard.kde.org/r/121143/diff/
>
>
> Testing
> -------
>
> Fully translated GUI in kate/kwrite
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============3358687939675983750==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121143/">https://git.reviewboard.kde.org/r/121143/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good to me.</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 16th, 2014, 8:27 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2014, 8:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Translation messages in src/data/katepartui.rc are \
extracted into the catalog ktexteditor5</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Without the definition \
of translationDomain in katepartui the queries for the translation of these strings \
in katepartui.rc are performed with the application translationDomain (e.g. "kate" \
or "kwrite") and the strings are untranslated in the GUI.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ the \
queries for translation of these strings in katepartui.rc are performed with the \
translationDomain "ktexteditor5" and e.g. the menu items in kate/kwrite are fully \
translated now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fully translated GUI in kate/kwrite</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/data/katepartui.rc <span style="color: grey">(6673b64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121143/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3358687939675983750==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic