'Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-11-16 18:40:16
Message-ID: 20141116184016.22979.36782 () probe ! kde ! org
[Download RAW message or body]

--===============9157654069801145508==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120902/
-----------------------------------------------------------

(Updated Nov. 16, 2014, 6:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Bugs: 339863
    https://bugs.kde.org/show_bug.cgi?id=339863

Repository: kwidgetsaddons

Description
-------

The old code converted the yellow star icon to grayscale for the unrated part. With \
icon themes that have no color, this means the rating cannot be read, because all \
stars look identical.

This code adds support for a "rating-unrated" icon that theme creators can use for \
the unrated part. If the icon theme does not support this icon, it falls back to \
desaturating.

Diffs
-----

  src/kratingpainter.cpp 8e8a6a3 

Diff: https://git.reviewboard.kde.org/r/120902/diff/

Testing
-------

I couldn't actually test with breeze theme (Qt issue?), but I locally added a \
dedicated "rating-unrated.png" file to oxygen and tested both cases (present and \
not).

Thanks,

Christoph Feck

--===============9157654069801145508==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120902/">https://git.reviewboard.kde.org/r/120902/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated Nov. 16, 2014, 6:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=339863">339863</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The old code converted the yellow star icon to \
grayscale for the unrated part. With icon themes that have no color, this means the \
rating cannot be read, because all stars look identical.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
code adds support for a "rating-unrated" icon that theme creators can use for the \
unrated part. If the icon theme does not support this icon, it falls back to \
desaturating.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I couldn't actually test with breeze theme (Qt \
issue?), but I locally added a dedicated "rating-unrated.png" file to oxygen and \
tested both cases (present and not).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kratingpainter.cpp <span style="color: grey">(8e8a6a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120902/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9157654069801145508==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 