'Re: Review Request 120888: add a new KNotification::Event with icon name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-frameworks-devel
Subject: Re: Review Request 120888: add a new KNotification::Event with icon name
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-10-30 12:25:41
Message-ID: 20141030122541.23656.61690 () probe ! kde ! org
[Download RAW message or body]

--===============4120987204875395295==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Oct. 30, 2014, 12:18 p.m., Christoph Feck wrote:
> > This seems to introduce a source-incompatible change, see build failure in \
> > kruler/frameworks: http://paste.opensuse.org/68026650

oops, already fixed

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120888/#review69522
-----------------------------------------------------------

On Oct. 29, 2014, 1:56 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120888/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> for
> https://bugs.kde.org/show_bug.cgi?id=321688
> 
> 
> Diffs
> -----
> 
> src/knotification.h 815d195 
> src/knotification.cpp 8421eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/120888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============4120987204875395295==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120888/">https://git.reviewboard.kde.org/r/120888/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 On October 30th, 2014, 12:18 p.m. UTC, Christoph Feck \
wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This seems to introduce a \
source-incompatible change, see build failure in kruler/frameworks: \
http://paste.opensuse.org/68026650</pre> </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">oops, already fixed</p></pre> <br \
/>

<p>- Christoph</p>

<br />
<p>On October 29th, 2014, 1:56 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2014, 1:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for \
https://bugs.kde.org/show_bug.cgi?id=321688</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/knotification.h <span style="color: grey">(815d195)</span></li>

 <li>src/knotification.cpp <span style="color: grey">(8421eaf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120888/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4120987204875395295==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 