'Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-10-30 2:02:32
Message-ID: 20141030020232.23656.71498 () probe ! kde ! org
[Download RAW message or body]

--===============0740015704946114472==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120904/
-----------------------------------------------------------

Review request for KDE Frameworks and Daniel Laidig.

Repository: kwidgetsaddons

Description
-------

To be able to fix bug 142625 we need new API in KCharSelect.

I am not completely sure if we should do it in KWidgetsAddons at all, because the \
required data updates might unreasonable blow up the size of the repository, but I \
just came up with this proposal for the API. Note that only the header diff is shown \
for the API review, the .cpp changes can be done after we settle for something.

Some things to discuss:
* uint is used by static QChar functions as the datatype, I adopted it
* it might make sense to have a function that returns the currently selected \
character(s) as a simple QString, with all UTF-16 handling already done. Naming \
suggestions?

Diffs
-----

  src/kcharselect.h ec93d21 

Diff: https://git.reviewboard.kde.org/r/120904/diff/

Testing
-------

No.

Thanks,

Christoph Feck

--===============0740015704946114472==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120904/">https://git.reviewboard.kde.org/r/120904/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Daniel Laidig.</div>
<div>By Christoph Feck.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To be able to fix bug 142625 we need new API in \
KCharSelect.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I am not completely sure if we should do it in \
KWidgetsAddons at all, because the required data updates might unreasonable blow up \
the size of the repository, but I just came up with this proposal for the API. Note \
that only the header diff is shown for the API review, the .cpp changes can be done \
after we settle for something.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Some things to discuss: \
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> uint is used by static QChar functions as the \
datatype, I adopted it </em> it might make sense to have a function that returns the \
currently selected character(s) as a simple QString, with all UTF-16 handling already \
done. Naming suggestions?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcharselect.h <span style="color: grey">(ec93d21)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120904/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0740015704946114472==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 