'Re: Review Request 120813: Set shortcuts via invoked meta method'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120813: Set shortcuts via invoked meta method
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-10-28 23:14:51
Message-ID: 20141028231451.23655.75243 () probe ! kde ! org
[Download RAW message or body]

--===============8661004380784172463==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120813/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 11:14 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, David Faure and Daniel Laidig.

Repository: kwidgetsaddons

Description
-------

While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still \
uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().

This adds code to invoke setDefaultShortcuts() via QMetaObject - same as for addAction() - so \
that KCharSelect widget class does not need to depend on kxmlgui.

For the KActionCollection patch see https://git.reviewboard.kde.org/r/120812/

Diffs
-----

  src/kcharselect.cpp 0d345a4 

Diff: https://git.reviewboard.kde.org/r/120813/diff/

Testing
-------

None.

Thanks,

Christoph Feck

--===============8661004380784172463==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120813/">https://git.reviewboard.kde.org/r/120813/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Daniel Laidig.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated Oct. 28, 2014, 11:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While porting \
KCharSelect application to KF5, I noticed that KCharSelect widget class still uses \
QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This adds code to invoke setDefaultShortcuts() via QMetaObject - same as for \
addAction() - so that KCharSelect widget class does not need to depend on kxmlgui.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For the KActionCollection patch see \
https://git.reviewboard.kde.org/r/120812/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">None.</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcharselect.cpp <span style="color: grey">(0d345a4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120813/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8661004380784172463==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 