'Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()
From:       "Alexander Richardson" <arichardson.kde () gmail ! com>
Date:       2014-10-27 21:45:52
Message-ID: 20141027214552.23656.84675 () probe ! kde ! org
[Download RAW message or body]

--===============0151557585182823371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120833/
-----------------------------------------------------------

Review request for KDE Frameworks, David Faure and Sebastian Kügler.

Repository: kcoreaddons

Description
-------

This means that e.g. KPluginLoader::findPlugin("/usr/lib/plugins/foo")
can now return "/usr/lib/plugins/foo.so" instead of an empty string.

Should this be done in Qt instead?

Diffs
-----

  autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 
  src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 

Diff: https://git.reviewboard.kde.org/r/120833/diff/

Testing
-------

Unit test passes

Thanks,

Alexander Richardson

--===============0151557585182823371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120833/">https://git.reviewboard.kde.org/r/120833/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Sebastian Kügler.</div>
<div>By Alexander Richardson.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This means that e.g. \
KPluginLoader::findPlugin("/usr/lib/plugins/foo") can now return \
"/usr/lib/plugins/foo.so" instead of an empty string.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Should this be done in Qt instead?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit test passes</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kpluginloadertest.cpp <span style="color: \
grey">(3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46)</span></li>

 <li>src/lib/plugin/kpluginloader.cpp <span style="color: \
grey">(802ef843bca4526cc9a4ee6780e8125453786b12)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120833/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0151557585182823371==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 