'Re: Review Request 120812: Allow setDefaultShortcuts() to be invoked via QMetaObject'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120812: Allow setDefaultShortcuts() to be invoked via QMetaObject
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-10-27 21:21:36
Message-ID: 20141027212136.23656.22838 () probe ! kde ! org
[Download RAW message or body]

--===============6327463651619651623==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120812/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 9:21 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.

Repository: kxmlgui

Description
-------

While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still \
uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().

This adds Q_INVOKABLE to setDefaultShortcuts() - same as for addAction() - so that KCharSelect \
widget class does not need to depend on kxmlgui.

For the KCharSelect patch see https://git.reviewboard.kde.org/r/120813/

Diffs
-----

  src/kactioncollection.h 243ef09 

Diff: https://git.reviewboard.kde.org/r/120812/diff/

Testing
-------

None, I have to wait until buildservice picks it up :P

Thanks,

Christoph Feck

--===============6327463651619651623==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120812/">https://git.reviewboard.kde.org/r/120812/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated Oct. 27, 2014, 9:21 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While porting \
KCharSelect application to KF5, I noticed that KCharSelect widget class still uses \
QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This adds Q_INVOKABLE to setDefaultShortcuts() - same as for addAction() - so that \
KCharSelect widget class does not need to depend on kxmlgui.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the \
KCharSelect patch see https://git.reviewboard.kde.org/r/120813/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">None, I have to \
wait until buildservice picks it up :P</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kactioncollection.h <span style="color: grey">(243ef09)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120812/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6327463651619651623==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 