'Re: Review Request 120666: Get user's permission before executing scripts or desktop files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-frameworks-devel
Subject: Re: Review Request 120666: Get user's permission before executing scripts or desktop files
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-10-23 22:10:04
Message-ID: 20141023221004.18178.81397 () probe ! kde ! org
[Download RAW message or body]

--===============5138068411708711050==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote:
> > src/widgets/krun.cpp, line 1013
> > <https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013>
> > 
> > Any reason why using show instead of exec? Exec would avoid the rather complex \
> > and error-prone code path. 
> > IMHO we should prefer a blocking dialog in this case, because it asks the user \
> > for permission.
> 
> Arjun AK wrote:
> > IMHO we should prefer a blocking dialog in this case, because it asks the user \
> > for permission.
> 
> faure: Are you okay with this?
> 
> Frank Reininghaus wrote:
> Note that you have to be *extremely* careful when calling exec(), which runs a \
> nested event loop. Anything can happen inside such a loop, including quitting the \
> application. See https://git.reviewboard.kde.org/r/118858/ and the links in the \
> comments there fore more information. 
> If you replace show() by exec() in your patch, you might get a crash in the line
> 
> m_dialogNotYetShown = false;
> 
> if the application quits inside the nested event loop.

> m_dialogNotYetShown = false;

This variable won't be needed anymore. Only the result of exec() is needed.

- Emmanuel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/#review68990
-----------------------------------------------------------

On Oct. 22, 2014, 6:10 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120666/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch makes KIO show a dialog box asking the user what to do (either open it \
> using a text editor or execute it) when he clicks on a script or a desktop file. 
> See also: https://git.reviewboard.kde.org/r/120171/
> 
> 
> Diffs
> -----
> 
> src/widgets/CMakeLists.txt 4060cdf 
> src/widgets/executablefileopendialog.h PRE-CREATION 
> src/widgets/executablefileopendialog.cpp PRE-CREATION 
> src/widgets/krun.cpp 6ac42da 
> src/widgets/krun_p.h 69e2e98 
> 
> Diff: https://git.reviewboard.kde.org/r/120666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
> 

--===============5138068411708711050==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120666/">https://git.reviewboard.kde.org/r/120666/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 23rd, 2014, 1:14 p.m. CEST, <b>Emmanuel \
Pescosta</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/krun.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1010</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">dialog</span><span class="o">-&gt;</span><span class="n">show</span><span \
class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
reason why using show instead of exec? Exec would avoid the rather complex and \
error-prone code path.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">IMHO we should prefer a blocking dialog \
in this case, because it asks the user for permission.</p></pre>  </blockquote>

 <p>On October 23rd, 2014, 3:59 p.m. CEST, <b>Arjun AK</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">IMHO we should prefer a blocking dialog in this case, because it asks the \
user for permission.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">faure: Are you okay with this?</p></pre>  \
</blockquote>

 <p>On October 24th, 2014, 12:03 a.m. CEST, <b>Frank Reininghaus</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note \
that you have to be <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">extremely</em> careful when calling \
exec(), which runs a nested event loop. Anything can happen inside such a loop, \
including quitting the application. See https://git.reviewboard.kde.org/r/118858/ and \
the links in the comments there fore more information.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you replace show() by exec() in your patch, you might get a crash in the line</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">m_dialogNotYetShown = false;</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">if the application \
quits inside the nested event loop.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> m_dialogNotYetShown = false; </blockquote>
This variable won't be needed anymore. Only the result \
of exec() is needed.</pre>

<p>- Emmanuel</p>

<br />
<p>On October 22nd, 2014, 6:10 p.m. CEST, Arjun AK wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Arjun AK.</div>

<p style="color: grey;"><i>Updated Oct. 22, 2014, 6:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes KIO show a dialog box asking the user \
what to do (either open it using a text editor or execute it) when he clicks on a \
script or a desktop file.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">See also: \
https://git.reviewboard.kde.org/r/120171/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/widgets/CMakeLists.txt <span style="color: grey">(4060cdf)</span></li>

 <li>src/widgets/executablefileopendialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/widgets/executablefileopendialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/widgets/krun.cpp <span style="color: grey">(6ac42da)</span></li>

 <li>src/widgets/krun_p.h <span style="color: grey">(69e2e98)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120666/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5138068411708711050==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 