'Re: Review Request 120435: Declare InheritanceChecker before actual use'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120435: Declare InheritanceChecker before actual use
From:       "Ben Cooksley" <bcooksley () kde ! org>
Date:       2014-10-04 11:37:50
Message-ID: 20141004113750.15675.50764 () probe ! kde ! org
[Download RAW message or body]

--===============0812136675633142601==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120435/#review67901
-----------------------------------------------------------

This can go in from my point of view, as long as it has no BC implications.

- Ben Cooksley

On Sept. 30, 2014, 11:36 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120435/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Ben Cooksley.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Declare InheritanceChecker before actual use
> 
> This is actually not needed for "proper" compilers, because the use is inside a \
> template, The type is only required at instantiation time.
> 
> However, this patch makes the Coverity build tool happy. Without this patch,
> we get an error for every translation unit including
> kpluginfactory.h, telling us that "InheritanceChecker is not a
> template"
> 
> Also see https://communities.coverity.com/thread/2903
> 
> 
> Diffs
> -----
> 
> src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 
> 
> Diff: https://git.reviewboard.kde.org/r/120435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
> 

--===============0812136675633142601==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120435/">https://git.reviewboard.kde.org/r/120435/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
can go in from my point of view, as long as it has no BC implications.</p></pre>  <br \
/>

<p>- Ben Cooksley</p>

<br />
<p>On September 30th, 2014, 11:36 a.m. UTC, Kevin Funk wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Ben Cooksley.</div>
<div>By Kevin Funk.</div>

<p style="color: grey;"><i>Updated Sept. 30, 2014, 11:36 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Declare InheritanceChecker before actual use

This is actually not needed for &quot;proper&quot; compilers, because the use is \
inside a template, The type is only required at instantiation time.

However, this patch makes the Coverity build tool happy. Without this patch,
we get an error for every translation unit including
kpluginfactory.h, telling us that &quot;InheritanceChecker is not a
template&quot;

Also see https://communities.coverity.com/thread/2903</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/plugin/kpluginfactory.h <span style="color: \
grey">(70ffade3e071b839245b9b0d6468f7b804478178)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120435/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0812136675633142601==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 