[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 120283: make KConfigLoader more predictable by exposing a getter to KConfig's Ope
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2014-09-19 14:21:57
Message-ID: 20140919142157.7376.97521 () probe ! kde ! org
[Download RAW message or body]
--===============8610531031110947205==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120283/
-----------------------------------------------------------
(Updated Sept. 19, 2014, 2:21 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Matthew Dawson.
Repository: kconfig
Description
-------
When opening a KSharedConfig, the OpenFlags must match to share the underlying config \
object. Otherwise a new KConfig is created and the benefit of using KSharedConfig is \
lost. This was triggering subtle bugs with the use of KConfigLoader in plasmashell.
This patchset adddress that issue by exposing the OpenFlags used to open a KConfig.
Another approach would be to add another KSharedConfig::openConfig() which takes a \
KConfig object and uses that in its search for a matching pointer object, and then \
use that version of openConfig in KSharedConfig
Diffs
-----
src/core/kconfig.h d7d4b7df8f33e33a389527d47d02fc844b74aed3
src/core/kconfig.cpp c6dec43641611bf14c5eb04d3007dd9016bcb3c8
src/gui/kconfigloader.cpp 52ac6d17b427a6eb8519699f642759b7ae672b81
Diff: https://git.reviewboard.kde.org/r/120283/diff/
Testing
-------
Used KConfigLoader in startup config of plasmashell and settings are now propagated \
correctly from the shell scripting to the config loader objects.
Thanks,
Aaron J. Seigo
--===============8610531031110947205==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120283/">https://git.reviewboard.kde.org/r/120283/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When opening a KSharedConfig, the OpenFlags must match \
to share the underlying config object. Otherwise a new KConfig is created and the \
benefit of using KSharedConfig is lost. This was triggering subtle bugs with the use \
of KConfigLoader in plasmashell.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patchset adddress \
that issue by exposing the OpenFlags used to open a KConfig.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Another approach would be to add another KSharedConfig::openConfig() which \
takes a KConfig object and uses that in its search for a matching pointer object, and \
then use that version of openConfig in KSharedConfig</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Used KConfigLoader in startup config of plasmashell \
and settings are now propagated correctly from the shell scripting to the config \
loader objects.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kconfig.h <span style="color: \
grey">(d7d4b7df8f33e33a389527d47d02fc844b74aed3)</span></li>
<li>src/core/kconfig.cpp <span style="color: \
grey">(c6dec43641611bf14c5eb04d3007dd9016bcb3c8)</span></li>
<li>src/gui/kconfigloader.cpp <span style="color: \
grey">(52ac6d17b427a6eb8519699f642759b7ae672b81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120283/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8610531031110947205==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic