'Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2014-09-06 6:55:22
Message-ID: 20140906065522.11808.41012 () probe ! kde ! org
[Download RAW message or body]

--===============2580801868522748667==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120062/#review65873
-----------------------------------------------------------

Ship it!

Ship It!

- Kevin Ottens

On Sept. 5, 2014, 8:39 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120062/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 8:39 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, Friedrich W. \
> H. Kossebau, and Laurent Montel. 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> This simplifies app development, which otherwise needs to write everything
> twice, like this:
> m_actFullScreen->setShortcut(Qt::Key_F11)
> collection->setDefaultShortcut(m_actFullScreen, Qt::Key_F11);
> 
> 
> Diffs
> -----
> 
> autotests/kactioncollectiontest.cpp 9047b32b3909371b42a9b26c79c5a58376a84783 
> src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa 
> src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 
> 
> Diff: https://git.reviewboard.kde.org/r/120062/diff/
> 
> 
> Testing
> -------
> 
> kactioncollectiontest now skips calling setShortcut if it's the same as the \
> default, and still passes. 
> 
> Thanks,
> 
> David Faure
> 
> 

--===============2580801868522748667==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120062/">https://git.reviewboard.kde.org/r/120062/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Kevin Ottens</p>

<br />
<p>On September 5th, 2014, 8:39 a.m. UTC, David Faure wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, Friedrich \
W. H. Kossebau, and Laurent Montel.</div> <div>By David Faure.</div>

<p style="color: grey;"><i>Updated Sept. 5, 2014, 8:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This simplifies app development, which otherwise needs \
to write everything<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> twice, like this:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
m_actFullScreen->setShortcut(Qt::Key_F11)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
collection->setDefaultShortcut(m_actFullScreen, Qt::Key_F11);</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kactioncollectiontest now skips calling setShortcut if \
it's the same as the default, and still passes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kactioncollectiontest.cpp <span style="color: \
grey">(9047b32b3909371b42a9b26c79c5a58376a84783)</span></li>

 <li>src/kactioncollection.h <span style="color: \
grey">(5dbc3c2ddd8f93af9874454d735ad2a237bf4afa)</span></li>

 <li>src/kactioncollection.cpp <span style="color: \
grey">(6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120062/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2580801868522748667==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 