[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119594: fix FileDialog size restorage
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-09-05 19:01:58
Message-ID: 20140905190158.11809.284 () probe ! kde ! org
[Download RAW message or body]
--===============3949994415414312176==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 7:01 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and \
Martin Klapetek.
Repository: frameworkintegration
Description
-------
- saving in the deconstrutor is insufficient,
the dialog might survive the runtime
-> needs to be saved when the dialog is finished or just closed
(the closeEvent is not invoked if at least a sync dialog is finished)
- ensure a windowHandle and then restore the window size before calling ::exec()
- workaround an apparent QWidget QPA bug where even for a created platform window
the QWindow geometry is not applied on the QWidget
Diffs
-----
src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7
src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e
src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1
src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5
Diff: https://git.reviewboard.kde.org/r/119594/diff/
Testing
-------
See
https://git.reviewboard.kde.org/r/119512/
Thanks,
Thomas Lübking
--===============3949994415414312176==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119594/">https://git.reviewboard.kde.org/r/119594/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, \
and Martin Klapetek.</div> <div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2014, 7:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">saving in the deconstrutor is insufficient,<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
the dialog might survive the runtime<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
-> needs to be saved when the dialog is finished or just closed<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> (the closeEvent is not invoked if at least a sync dialog is \
finished)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">ensure a windowHandle and then restore \
the window size before calling ::exec()</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">workaround an apparent QWidget QPA bug \
where even for a created platform window<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> the QWindow geometry \
is not applied on the QWidget</p> </li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
https://git.reviewboard.kde.org/r/119512/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/kdeplatformfiledialogbase.cpp <span style="color: \
grey">(b823bc7)</span></li>
<li>src/platformtheme/kdeplatformfiledialogbase_p.h <span style="color: \
grey">(8ef5b1e)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: \
grey">(406a4f1)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(520b6f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119594/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3949994415414312176==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic