[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-08-30 1:24:10
Message-ID: 20140830012410.14965.81687 () probe ! kde ! org
[Download RAW message or body]
--===============3018670035360152696==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote:
> > +1 looks good to me.
> >
> > Maybe a before/after screenshot would help in these reviews.
>
> Hugo Pereira Da Costa wrote:
> sorry. Will add
> (being lazy)
>
> Ben Cooksley wrote:
> You may wish to examine System Settings, it has very similar code as well (If I \
> recall correctly, the tooltip rendering code was copied between them - and \
> originally came from Dolphin).
> Hugo Pereira Da Costa wrote:
> Hi Ben,
> it appears systemsetting's tooltips painting was already fixed a while ago (just \
> double checked) no artifact, stylePainter is already used there (and so is the case \
> for dolphin)
> Btw: I wonder if this tooltip widget/manager would be a good candidate for \
> kwidgetsaddons, so that applications would not have to duplicate the code (what you \
> actually put in the tooltips contents being still the responsibility of the \
> application)
Okay, thanks for checking. I concur that it probably would be a good candidate for \
being placed in a library - not sure who wrote the code though, so you'd probably \
have to rewrite it.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119940/#review65279
-----------------------------------------------------------
On Aug. 26, 2014, 2:43 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119940/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 2:43 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kinfocenter
>
>
> Description
> -------
>
> as title says
> the current custom code was made to match oxygen, and does not fit breeze any more.
> You end up with artifacts, incorrect rounding, wrong shadow etc.
> also the current code is much simpler and works with all other themes too
>
>
> Diffs
> -----
>
> ToolTips/ktooltipwindow.cpp 0ef540c
> ToolTips/ktooltipwindow_p.h a9ac30f
>
> Diff: https://git.reviewboard.kde.org/r/119940/diff/
>
>
> Testing
> -------
>
> with oxygen, fusion, breeze
>
>
> File Attachments
> ----------------
>
> kinfocenter-before.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/344a7dab-0dce-4a80-915b-8fccbd1b9f16__kinfocenter-before.png
> kinfocenter-after.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/dc2d618e-077f-4f49-ba02-11420927a068__kinfocenter-after.png
>
>
> Thanks,
>
> Hugo Pereira Da Costa
>
>
--===============3018670035360152696==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119940/">https://git.reviewboard.kde.org/r/119940/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 26th, 2014, 2:21 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1 looks good to me.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
a before/after screenshot would help in these reviews.</p></pre> </blockquote>
<p>On August 26th, 2014, 2:36 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">sorry. Will add<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> (being lazy)</p></pre>
</blockquote>
<p>On August 26th, 2014, 7:57 p.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
may wish to examine System Settings, it has very similar code as well (If I recall \
correctly, the tooltip rendering code was copied between them - and originally came \
from Dolphin).</p></pre> </blockquote>
<p>On August 27th, 2014, 7:40 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Ben, <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> it appears systemsetting's tooltips painting was \
already fixed a while ago (just double checked)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> no artifact, \
stylePainter is already used there (and so is the case for dolphin)<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Btw: I wonder if this tooltip widget/manager would be a good candidate for \
kwidgetsaddons, so that applications would not have to duplicate the code<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> (what you actually put in the tooltips contents being still the \
responsibility of the application)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okay, \
thanks for checking. I concur that it probably would be a good candidate for being \
placed in a library - not sure who wrote the code though, so you'd probably have to \
rewrite it.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On August 26th, 2014, 2:43 p.m. UTC, Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2014, 2:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinfocenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">as title says<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> the current custom \
code was made to match oxygen, and does not fit breeze any more.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> You \
end up with artifacts, incorrect rounding, wrong shadow etc.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
also the current code is much simpler and works with all other themes too</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with oxygen, fusion, breeze</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ToolTips/ktooltipwindow.cpp <span style="color: grey">(0ef540c)</span></li>
<li>ToolTips/ktooltipwindow_p.h <span style="color: grey">(a9ac30f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119940/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/344a7dab \
-0dce-4a80-915b-8fccbd1b9f16__kinfocenter-before.png">kinfocenter-before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/dc2d618e \
-077f-4f49-ba02-11420927a068__kinfocenter-after.png">kinfocenter-after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3018670035360152696==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic