[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-08-29 14:56:41
Message-ID: 20140829145641.11204.71650 () probe ! kde ! org
[Download RAW message or body]
--===============4296206291317219575==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119992/#review65507
-----------------------------------------------------------
Ship it!
this having both defines should make old users build without problems.
+1 for me..
- Marco Martin
On Aug. 29, 2014, 2:20 p.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119992/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 2:20 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This patch removes dead code (ContainmentPackage), clean up DataEngine plugin \
> loading and updates PackageStructure plugin loading.
> Open question: which plugin loading mechanism is to be used:
>
> a) KServiceTypeTrader
> b) KPluginTrader
> c) KPlugintTrader with a KServiceTypeTrade fallback
> d) KServiceTypeTrader with a KPluginTrader fallback
>
> DataEngine is currently (b), complete with a #define in the header that won't work \
> as expected. In this patch PackageStructure is moved to (b) as well. (There is an \
> open RR for a correponding patch set in plasma-workspace). Everything else seems to \
> use (a).
> Some plugins are not used in Plasma 5 due to changes with QML, and I guess that \
> some of this confusion is due to the decreased use of some of these plugins. A \
> decision needs to be made, however about what they should be now and in the future. \
>
> Diffs
> -----
>
> src/plasma/pluginloader.cpp d2ba5ca2d3a96fe6f1ce26be41df3b0954b924df
> src/plasma/private/packages.cpp 5eb6f0021392257634dfd958c940b2945989e48b
> src/plasma/private/packages_p.h 0833a4ed1b5704efffccade5e52589878e8b4957
> src/plasma/package.cpp 6ad332167bb83c2f794f9f5d059e9f369ad33841
> src/plasma/packagestructure.h fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3
>
> Diff: https://git.reviewboard.kde.org/r/119992/diff/
>
>
> Testing
> -------
>
> Ran a Plasma Desktop 5 session with these changes.
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
--===============4296206291317219575==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119992/">https://git.reviewboard.kde.org/r/119992/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
having both defines should make old users build without problems.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> +1 \
for me..</p></pre> <br />
<p>- Marco Martin</p>
<br />
<p>On August 29th, 2014, 2:20 p.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 2:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch removes dead code (ContainmentPackage), \
clean up DataEngine plugin loading and updates PackageStructure plugin loading.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Open question: which plugin loading mechanism is to be \
used:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">a) KServiceTypeTrader<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> b) \
KPluginTrader<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> c) KPlugintTrader with a KServiceTypeTrade \
fallback<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> d) KServiceTypeTrader with a KPluginTrader \
fallback</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DataEngine is currently (b), complete with a #define \
in the header that won't work as expected.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In this patch \
PackageStructure is moved to (b) as well. (There is an open RR for a correponding \
patch set in plasma-workspace).<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Everything else seems to use (a).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Some plugins are not used in Plasma 5 due to changes \
with QML, and I guess that some of this confusion is due to the decreased use of some \
of these plugins. A decision needs to be made, however about what they should be now \
and in the future.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran a Plasma Desktop 5 session with these \
changes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/pluginloader.cpp <span style="color: \
grey">(d2ba5ca2d3a96fe6f1ce26be41df3b0954b924df)</span></li>
<li>src/plasma/private/packages.cpp <span style="color: \
grey">(5eb6f0021392257634dfd958c940b2945989e48b)</span></li>
<li>src/plasma/private/packages_p.h <span style="color: \
grey">(0833a4ed1b5704efffccade5e52589878e8b4957)</span></li>
<li>src/plasma/package.cpp <span style="color: \
grey">(6ad332167bb83c2f794f9f5d059e9f369ad33841)</span></li>
<li>src/plasma/packagestructure.h <span style="color: \
grey">(fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119992/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4296206291317219575==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic