'Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing
From:       "Alexander Richardson" <arichardson.kde () gmail ! com>
Date:       2014-08-19 21:38:32
Message-ID: 20140819213832.26013.82856 () probe ! kde ! org
[Download RAW message or body]

--===============2430384798864271247==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119849/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kwindowsystem

Description
-------

This is what would be printed previously:

CMake Error: The following variables are used in this project, but they are set to \
NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake \
files: X11_Xrender_LIB (ADVANCED)
    linked by target "KF5WindowSystem" in directory /foo/bar

Now we print:

The XRender library could not be found. Please install the development package for \
it.

Diffs
-----

  src/CMakeLists.txt 2794ed1e6f56ed521d845bc20ba1c027493e14e7 

Diff: https://git.reviewboard.kde.org/r/119849/diff/

Testing
-------

Thanks,

Alexander Richardson

--===============2430384798864271247==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119849/">https://git.reviewboard.kde.org/r/119849/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is what would be printed previously:

CMake Error: The following variables are used in this project, but they are set to \
NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake \
files: X11_Xrender_LIB (ADVANCED)
    linked by target &quot;KF5WindowSystem&quot; in directory /foo/bar

Now we print:

The XRender library could not be found. Please install the development package for \
it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: \
grey">(2794ed1e6f56ed521d845bc20ba1c027493e14e7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119849/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2430384798864271247==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 