From kde-frameworks-devel Tue Aug 19 19:43:13 2014 From: "David Edmundson" Date: Tue, 19 Aug 2014 19:43:13 +0000 To: kde-frameworks-devel Subject: Re: Review Request 119846: qtcontrols port for checkbox and radiobutton Message-Id: <20140819194313.26014.28883 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=140847741227228 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6595881208047941801==" --===============6595881208047941801== Content-Type: multipart/alternative; boundary="===============6275359933835023809==" --===============6275359933835023809== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64882 ----------------------------------------------------------- src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml Good question. I think it is needed to set background to something otherwise it will use the one in the Base style. src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml checked isn't a boolean, it's an enum of the checked, partial, unchecked. src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml Can/should this be fixed inside the SVGs? Otherwise we're doing breeze hacks at a code level, a themer who creates both as rectangles will get one inexplicably larger - David Edmundson On Aug. 19, 2014, 5:21 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119846/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 5:21 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports checkbox and radiobuttons (and switch that at least on desktop formfactor is just an alias for checkboxes) to qtcontrols and adds the corresponding styles > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/CheckBox.qml 5e98d11 > src/declarativeimports/plasmacomponents/qml/RadioButton.qml 00a1bbf > src/declarativeimports/plasmacomponents/qml/Switch.qml d0608f9 > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml PRE-CREATION > src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119846/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > > --===============6275359933835023809== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/

src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml (Diff revision 1)
		33	//Not needed?

Good question.

I think it is needed to set background to something otherwise it will use the one in the Base style.

src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml (Diff revision 1)
		51	opacity: control.checked ? 1 : 0

checked isn't a boolean, it's an enum of the checked, partial, unchecked.

src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml (Diff revision 1)
		44	//slightly bigger then the checkbox: being round its apparent size is smaller

Can/should this be fixed inside the SVGs?

Otherwise we're doing breeze hacks at a code level, a themer who creates both as rectangles will get one inexplicably larger

- David Edmundson

On August 19th, 2014, 5:21 p.m. UTC, Marco Martin wrote:

Review request for KDE Frameworks and Plasma.

By Marco Martin.

Updated Aug. 19, 2014, 5:21 p.m.

Repository: plasma-framework

Description

this ports checkbox and radiobuttons (and switch that at least on desktop formfactor is just an alias for checkboxes) to qtcontrols and adds the corresponding styles

Diffs

src/declarativeimports/plasmacomponents/qml/CheckBox.qml (5e98d11)
src/declarativeimports/plasmacomponents/qml/RadioButton.qml (00a1bbf)
src/declarativeimports/plasmacomponents/qml/Switch.qml (d0608f9)
src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml (PRE-CREATION)
src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml (PRE-CREATION)

--===============6275359933835023809==-- --===============6595881208047941801== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============6595881208047941801==--