[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119808: Move module metadata to after class picker
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2014-08-19 17:49:29
Message-ID: 20140819174929.26013.43388 () probe ! kde ! org
[Download RAW message or body]
--===============0124880969665527335==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 19, 2014, 10:19 a.m., Aleix Pol Gonzalez wrote:
> > I think it's disputable that the developers will want to interact with the "File \
> > List" more often. I think this shows we want a new design after all.
> > For the moment, I won't +1 or -1.
I'm admittedly going off how I personally use apidocs, which is to extensively use \
the class list and/or class picker, both of which are shoved off the bottom of the \
window for me with the current layout (while this patch makes both those and at least \
part of the module info section visible without scrolling).
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119808/#review64831
-----------------------------------------------------------
On Aug. 18, 2014, 10:04 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119808/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 10:04 p.m.)
>
>
> Review request for KDE Frameworks, Denis Steckelmacher and Aurélien Gâteau.
>
>
> Repository: kapidox
>
>
> Description
> -------
>
> This puts the things developers will want to access repeatedly at the
> top.
>
> Move module description out of sidebar header
>
> Multi-line headers look very odd, and this happens on multiple
> frameworks. The header instead has "About", and the description is a
> normal paragraph underneath.
>
>
> Diffs
> -----
>
> src/kapidox/data/htmlresource/kde.css e173dfe559d762b347815223c9e1e3ef3b0b7a4c
> src/kapidox/data/templates/doxygen.html d00e14e4b16e8d8ac1176cf2e73dd8dca02976d9
> src/kapidox/data/templates/fwinfo.html 8bba4b48b1a4937df6d5e809b9389d2c3ba123f3
>
> Diff: https://git.reviewboard.kde.org/r/119808/diff/
>
>
> Testing
> -------
>
> Built apidox with the changes, visually inspected KApiDox (long description) and \
> KArchive (short description).
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/18/66921e40-9e30-4231-a01e-da2d3c26d979__about_below_class_picker.png
>
>
> Thanks,
>
> Alex Merry
>
>
--===============0124880969665527335==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119808/">https://git.reviewboard.kde.org/r/119808/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 19th, 2014, 10:19 a.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think it's disputable that the developers will want \
to interact with the "File List" more often. I think this shows we want a new design \
after all.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For the moment, I won't +1 or -1.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
admittedly going off how I personally use apidocs, which is to extensively use the \
class list and/or class picker, both of which are shoved off the bottom of the window \
for me with the current layout (while this patch makes both those and at least part \
of the module info section visible without scrolling).</p></pre> <br />
<p>- Alex</p>
<br />
<p>On August 18th, 2014, 10:04 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Denis Steckelmacher and Aurélien \
Gâteau.</div> <div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2014, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This puts the things developers will want to access \
repeatedly at the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> top.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Move module description out of sidebar header</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Multi-line headers look very odd, and this happens on multiple<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> frameworks. The header instead has "About", and the description is a<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> normal paragraph underneath.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built apidox with the changes, visually inspected \
KApiDox (long description) and KArchive (short description).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kapidox/data/htmlresource/kde.css <span style="color: \
grey">(e173dfe559d762b347815223c9e1e3ef3b0b7a4c)</span></li>
<li>src/kapidox/data/templates/doxygen.html <span style="color: \
grey">(d00e14e4b16e8d8ac1176cf2e73dd8dca02976d9)</span></li>
<li>src/kapidox/data/templates/fwinfo.html <span style="color: \
grey">(8bba4b48b1a4937df6d5e809b9389d2c3ba123f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119808/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/18/66921e40-9e30-4231-a01e-da2d3c26d979__about_below_class_picker.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0124880969665527335==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic