[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119714: Fix the build on Windows using MSVC 2013
From: "Joseph Wenninger" <kde () jowenn ! at>
Date: 2014-08-11 13:51:00
Message-ID: 20140811135100.14668.66057 () probe ! kde ! org
[Download RAW message or body]
--===============1128890437557691404==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119714/#review64262
-----------------------------------------------------------
Ship it!
This should be save, default paramater is 0 anyways and internally in cute, the \
result is the same. It should not make a difference which overload is used.
inline QModelIndex(int arow, int acolumn, void *ptr, const QAbstractItemModel \
*amodel)
: r(arow), c(acolumn), i(reinterpret_cast<quintptr>(ptr)), m(amodel) {}
Q_DECL_CONSTEXPR inline QModelIndex(int arow, int acolumn, quintptr id, const \
QAbstractItemModel *amode$ : r(arow), c(acolumn), i(id), m(amodel) {}
- Joseph Wenninger
On Aug. 11, 2014, 1:24 nachm., Cristian Oneț wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119714/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 1:24 nachm.)
>
>
> Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> The compiler was complaining about ambiguous method resolution using
> QAbstractItemModel::createIndex (because of the last parameter) so just
> remove it since QAbstractItemModel::createIndex has a default value
> for the last parameter in one of the overloads which is just what it's
> needed.
>
>
> Diffs
> -----
>
> src/completion/katekeywordcompletion.cpp e30a64d7de3be0f6470303024b0fd0fc034a12dd
>
> Diff: https://git.reviewboard.kde.org/r/119714/diff/
>
>
> Testing
> -------
>
> Built and run kate.
>
>
> Thanks,
>
> Cristian Oneț
>
>
--===============1128890437557691404==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119714/">https://git.reviewboard.kde.org/r/119714/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
should be save, default paramater is 0 anyways and internally in cute, the result is \
the same. It should not make a difference which overload is used.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">inline QModelIndex(int arow, int acolumn, void <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">ptr, \
const QAbstractItemModel </em>amodel)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> : r(arow), \
c(acolumn), i(reinterpret_cast<quintptr>(ptr)), m(amodel) {}<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Q_DECL_CONSTEXPR inline QModelIndex(int arow, int acolumn, quintptr id, const \
QAbstractItemModel *amode$<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> : r(arow), c(acolumn), i(id), \
m(amodel) {}</p></pre> <br />
<p>- Joseph Wenninger</p>
<br />
<p>On August 11th, 2014, 1:24 nachm. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Christoph Cullmann and Joseph \
Wenninger.</div> <div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2014, 1:24 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The compiler was complaining about ambiguous method \
resolution using<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> QAbstractItemModel::createIndex (because of the last \
parameter) so just<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> remove it since \
QAbstractItemModel::createIndex has a default value<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> for \
the last parameter in one of the overloads which is just what it's<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
needed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built and run kate.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/completion/katekeywordcompletion.cpp <span style="color: \
grey">(e30a64d7de3be0f6470303024b0fd0fc034a12dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119714/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1128890437557691404==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic