[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2014-08-04 15:15:06
Message-ID: 20140804151506.20974.7748 () probe ! kde ! org
[Download RAW message or body]
--===============1853804090489261684==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On juin 7, 2014, 3:10 après-midi, David Faure wrote:
> > Very nice.
> >
> > The question of "why not in Qt" hasn't been answered though :)
>
> Aurélien Gâteau wrote:
> If you think this has a chance to get in, I can propose it.
>
> Aleix Pol Gonzalez wrote:
> I think it would be accepted. I'm at Qt Contributor Summit anyway, if anybody knows \
> who to ask I can physically poke him.
I don't have the time or energy to get this into Qt, but I am still happy to commit \
it here if you want. Just let me know.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59506
-----------------------------------------------------------
On juin 5, 2014, 2:38 après-midi, Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118514/
> -----------------------------------------------------------
>
> (Updated juin 5, 2014, 2:38 après-midi)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper \
> class I created long ago to help maintain uniform widths across layouts. You can \
> learn more about it from the blog post I wrote back then: \
> http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified \
> the API a bit, added some documentation, and here it is.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 854e916
> autotests/kcolumnresizertest-forms.ui PRE-CREATION
> autotests/kcolumnresizertest-grid-and-form.ui PRE-CREATION
> autotests/kcolumnresizertest-grids.ui PRE-CREATION
> autotests/kcolumnresizertest.h PRE-CREATION
> autotests/kcolumnresizertest.cpp PRE-CREATION
> docs/pics/kcolumnresizer.png PRE-CREATION
> src/CMakeLists.txt 27b9084
> src/kcolumnresizer.h PRE-CREATION
> src/kcolumnresizer.cpp PRE-CREATION
> tests/CMakeLists.txt eccf887
> tests/kcolumnresizertest.h PRE-CREATION
> tests/kcolumnresizertest.cpp PRE-CREATION
> tests/kcolumnresizertest.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118514/diff/
>
>
> Testing
> -------
>
> Manual test program behaves as expected.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
--===============1853804090489261684==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118514/">https://git.reviewboard.kde.org/r/118514/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On juin 7th, 2014, 3:10 après-midi CEST, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Very nice.
The question of "why not in Qt" hasn't been answered though :)</pre>
</blockquote>
<p>On juin 10th, 2014, 2:05 après-midi CEST, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you think this has a \
chance to get in, I can propose it.</pre> </blockquote>
<p>On juin 10th, 2014, 5:40 après-midi CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it would be \
accepted. I'm at Qt Contributor Summit anyway, if anybody knows who to ask I can \
physically poke him.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't have the time or energy to get this into Qt, but I am still happy to commit it \
here if you want. Just let me know.</p></pre> <br />
<p>- Aurélien</p>
<br />
<p>On juin 5th, 2014, 2:38 après-midi CEST, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated juin 5, 2014, 2:38 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer \
is a helper class I created long ago to help maintain uniform widths across layouts. \
You can learn more about it from the blog post I wrote back then: \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the \
API a bit, added some documentation, and here it is.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual test program behaves as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(854e916)</span></li>
<li>autotests/kcolumnresizertest-forms.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/kcolumnresizertest-grid-and-form.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/kcolumnresizertest-grids.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/kcolumnresizertest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/kcolumnresizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>docs/pics/kcolumnresizer.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(27b9084)</span></li>
<li>src/kcolumnresizer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcolumnresizer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(eccf887)</span></li>
<li>tests/kcolumnresizertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kcolumnresizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kcolumnresizertest.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118514/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1853804090489261684==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic