[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2014-07-31 18:53:46
Message-ID: 20140731185346.3288.11277 () probe ! kde ! org
[Download RAW message or body]
--===============2702771746431887590==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119365/#review63594
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
On July 19, 2014, 11:58 a.m., Cristian Oneț wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119365/
> -----------------------------------------------------------
>
> (Updated July 19, 2014, 11:58 a.m.)
>
>
> Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: khtml
>
>
> Description
> -------
>
> This patch addresses these build issues:
> 1. Some Qt5::X11Extras were not properly guarded.
> 2. KDEWin is needed on Windows for 'unistd.h' and others.
> 3. 'fmod' migth be a macro which will screw up calls to std::fmod
>
>
> Diffs
> -----
>
> CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087
> src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c
> src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02
> tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07
>
> Diff: https://git.reviewboard.kde.org/r/119365/diff/
>
>
> Testing
> -------
>
> Build & run on Windows and Linux.
>
>
> Thanks,
>
> Cristian Oneț
>
>
--===============2702771746431887590==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119365/">https://git.reviewboard.kde.org/r/119365/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On July 19th, 2014, 11:58 a.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl \
Sandsmark.</div> <div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated July 19, 2014, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch addresses these build issues:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> 1. Some Qt5::X11Extras were not properly guarded.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 2. \
KDEWin is needed on Windows for 'unistd.h' and others.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. \
'fmod' migth be a macro which will screw up calls to std::fmod</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build & run on Windows and Linux.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(de34f3c8d7479811d536fbce2114f29a96693087)</span></li>
<li>src/CMakeLists.txt <span style="color: \
grey">(bc7534667d6a39b334d038d55391e784c6527b1c)</span></li>
<li>src/html/html_canvasimpl.cpp <span style="color: \
grey">(18990eaa7ab00316471ecec0e9aa30b394aa4e02)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(d672fb56feb52da7308e844e0c86460e11778c07)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119365/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2702771746431887590==--
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic