[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119523: port TextField to QtControls
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-07-28 18:54:26
Message-ID: 20140728185426.15443.18237 () probe ! kde ! org
[Download RAW message or body]
--===============4029466271252896284==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63363
-----------------------------------------------------------
Even if we fix the methods it's too close to 5.1 to merge right now. Definitely wait \
till after that so we have some time to find problems.
src/declarativeimports/plasmacomponents/qml/TextField.qml
<https://git.reviewboard.kde.org/r/119523/#comment44165>
This is going to overlap with the text I think.
It might be worth trying to upstream the concept of a clear button rather than \
working round it here. It'll be less work in the long term.
I filed a bug report on this once, they're ok with the concept but want to make \
it so you can add any random button on the left/right, not just clear.
src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml
<https://git.reviewboard.kde.org/r/119523/#comment44164>
RAndon capitals
Which methods do we need the inner control for? I saw positionAtPos and \
positionToRectangle, any others?
- David Edmundson
On July 28, 2014, 6:10 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 6:10 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this ports TextField to Qt Controls.
>
> Not sure if is really meargeable tough, because the old one used to export several \
> properties and functions more, but they are not possible anymore, because in order \
> for them to work is needed the access to the internal TextInput, and we don't have \
> that, so some api should have to be dropped, breaking the compatibility promise. \
> (another option would be to still use an own implementation, but use a compatible \
> style anyways)
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58
> src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============4029466271252896284==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119523/">https://git.reviewboard.kde.org/r/119523/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Even \
if we fix the methods it's too close to 5.1 to merge right now. Definitely wait till \
after that so we have some time to find problems.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119523/diff/1/?file=293985#file293985line366" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/plasmacomponents/qml/TextField.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">362</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">PlasmaCore</span><span class="p">.</span><span class="nx">IconItem</span> \
<span class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">52</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="nx">PlasmaCore</span><span \
class="p">.</span><span class="nx">IconItem</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is going to overlap with the text I think.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> It might be worth \
trying to upstream the concept of a clear button rather than working round it here. \
It'll be less work in the long term. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I filed a bug report on \
this once, they're ok with the concept but want to make it so you can add any random \
button on the left/right, not just clear.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119523/diff/1/?file=293986#file293986line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">* Copyright (C) 2014 by Marco MArtin \
<mart@kde.org></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">RAndon capitals</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Which \
methods do we need the inner control for? I saw positionAtPos and \
positionToRectangle, any others?</p></pre>
<p>- David Edmundson</p>
<br />
<p>On July 28th, 2014, 6:10 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 28, 2014, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this ports TextField to Qt Controls.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not sure if is really meargeable tough, because the old one used to export \
several properties and functions more, but they are not possible anymore, because in \
order for them to work is needed the access to the internal TextInput, and we don't \
have that, so some api should have to be dropped, breaking the compatibility \
promise.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> (another option would be to still use an own \
implementation, but use a compatible style anyways)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(5bc6b58)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119523/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4029466271252896284==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic