From kde-frameworks-devel Sat Jul 12 19:38:30 2014 From: "Alex Merry" Date: Sat, 12 Jul 2014 19:38:30 +0000 To: kde-frameworks-devel Subject: Re: Review Request 119198: Don't search default paths when finding lconvert. Message-Id: <20140712193830.19520.9632 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=140519393525779 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4427178929744136689==" --===============4427178929744136689== Content-Type: multipart/alternative; boundary="===============6627984507878445118==" --===============6627984507878445118== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/#review62214 ----------------------------------------------------------- Ship it! Yep, seems sensible to me. We definitely want the lconvert that matches the lrelease we're using. - Alex Merry On July 9, 2014, 2:12 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119198/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 2:12 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one > will be used instead of the one alongside Qt5::lrelease. This could cause Qt4 > lconvert to be incorrectly used on some systems. > > > Diffs > ----- > > modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 > modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af > > Diff: https://git.reviewboard.kde.org/r/119198/diff/ > > > Testing > ------- > > When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. > > > Thanks, > > Michael Palimaka > > --===============6627984507878445118== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/

Ship it!

Yep, seems sensible to me. We definitely want the lconvert that matches the lrelease we're using.

- Alex Merry

On July 9th, 2014, 2:12 p.m. UTC, Michael Palimaka wrote:

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

By Michael Palimaka.

Updated July 9, 2014, 2:12 p.m.

Repository: extra-cmake-modules

Description

Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one
will be used instead of the one alongside Qt5::lrelease. This could cause Qt4
lconvert to be incorrectly used on some systems.

Testing

When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin.

Diffs

modules/ECMPoQmTools.cmake (3ce695817cb3da5ec9eebec86e632438c5941ee6)
modules/ECMCreateQmFromPoFiles.cmake (4a31a93e7900780dc5b9424b148f19f5c22061af)

View Diff

--===============6627984507878445118==-- --===============4427178929744136689== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============4427178929744136689==--