[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc
From: "David Faure" <faure () kde ! org>
Date: 2014-07-06 13:00:51
Message-ID: 20140706130051.26266.24155 () probe ! kde ! org
[Download RAW message or body]
--===============8327767604324880202==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 6, 2014, 12:52 p.m., Alex Merry wrote:
> > A little concerned that there are no documentation changes as part of this patch. \
> > Is this stuff noted in the apidocs?
> > Also, I assume that not changing the behaviour of setXMLFile is a deliberate \
> > decision. What's the reasoning? That should probably be noted in a comment or in \
> > the apidocs.
You're right that this could be documented in the kxmlgui apidocs. Note that (AFAICS) \
the old install location wasn't documented either.
I don't understand your second paragraph though. This patch DOES change the behaviour \
of setXMLFile: it looks in kxmlgui5/ first.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119142/#review61693
-----------------------------------------------------------
On July 6, 2014, 9:47 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119142/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 9:47 a.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Kevin Ottens.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc
>
> The old files (DATADIR/component_name/file.rc) can still be loaded,
> and a runtime warning is shown in such a case, telling people to install
> into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d)
>
> This keeps DATADIR slightly cleaner, getting rid of many application subdirs
> that would just contain a rc file. Some people seem to care about the cleanliness
> of their DATADIR :-)
>
>
> Diffs
> -----
>
> src/kedittoolbar.cpp 32512e9caccdbee1b07ff791fbecdcc817ca5726
> src/kxmlguiclient.cpp f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d
> src/kxmlguifactory.cpp aa657bcc24a949f4350975609f19fae8b6c9a4f0
>
> Diff: https://git.reviewboard.kde.org/r/119142/diff/
>
>
> Testing
> -------
>
> Running kwrite unmodified -> works, with runtime warning
> Porting kwrite to KXMLGUI_INSTALL_DIR -> works, runtime warning is gone
>
> I also did the same with konsole, special case since it called \
> setXMLFile("konsole/partui.rc"), had to be ported to setComponentName("konsole") + \
> setXMLFile("partui.rc") while porting to KXMLGUI_INSTALL_DIR. This patch is still \
> SC/BC, it's just a porting trap -- that affects none of the other existing \
> kf5-based apps though.
>
> Thanks,
>
> David Faure
>
>
--===============8327767604324880202==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119142/">https://git.reviewboard.kde.org/r/119142/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 6th, 2014, 12:52 p.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A little concerned that there are no documentation \
changes as part of this patch. Is this stuff noted in the apidocs?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also, I assume that not changing the behaviour of setXMLFile is a \
deliberate decision. What's the reasoning? That should probably be noted in a comment \
or in the apidocs.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You're right that this could be documented in the kxmlgui apidocs. Note \
that (AFAICS) the old install location wasn't documented either.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I don't understand your second paragraph though. This patch DOES change the \
behaviour of setXMLFile: it looks in kxmlgui5/ first.</p></pre> <br />
<p>- David</p>
<br />
<p>On July 6th, 2014, 9:47 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Alex Merry and Kevin Ottens.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 6, 2014, 9:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KXMLGUI: load .rc files from \
DATADIR/kxmlgui5/component_name/file.rc</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The old files \
(DATADIR/component_name/file.rc) can still be loaded,<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> and \
a runtime warning is shown in such a case, telling people to install<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This keeps DATADIR slightly cleaner, getting rid of \
many application subdirs<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> that would just contain a rc file. \
Some people seem to care about the cleanliness<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> of their DATADIR \
:-)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Running kwrite unmodified -> works, with runtime \
warning<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Porting kwrite to KXMLGUI_INSTALL_DIR -> works, \
runtime warning is gone</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I also did the same with konsole, \
special case since it called setXMLFile("konsole/partui.rc"), had to be ported to \
setComponentName("konsole") + setXMLFile("partui.rc") while porting to \
KXMLGUI_INSTALL_DIR. This patch is still SC/BC, it's just a porting trap -- that \
affects none of the other existing kf5-based apps though.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kedittoolbar.cpp <span style="color: \
grey">(32512e9caccdbee1b07ff791fbecdcc817ca5726)</span></li>
<li>src/kxmlguiclient.cpp <span style="color: \
grey">(f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d)</span></li>
<li>src/kxmlguifactory.cpp <span style="color: \
grey">(aa657bcc24a949f4350975609f19fae8b6c9a4f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119142/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8327767604324880202==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic