[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
From: "David Faure" <faure () kde ! org>
Date: 2014-07-06 12:57:36
Message-ID: 20140706125736.26267.61457 () probe ! kde ! org
[Download RAW message or body]
--===============6375279239768722277==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119145/#review61694
-----------------------------------------------------------
GenericDataLocation + env is polluting the global namespace. Imagine if gnome did the \
same...
My suggestion is GenericConfigLocation + "/startkde/env/"
or GenericConfigLocation + "/kde-workspace/env/".
Yes, this means adjusting the KCM as well, of course.
startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/119145/#comment42933>
concatenation doesn't really need sed.
- David Faure
On July 6, 2014, 12:52 p.m., Luca Beltrame wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119145/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 12:52 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and David Faure.
>
>
> Bugs: 333793
> https://bugs.kde.org/show_bug.cgi?id=333793
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Currently env and shutdown scripts in startkde are not run due to the way \
> kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found.
> This patch moves things to qtpaths, putting things under GenericDataLocation + \
> "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to \
> the discussion in [1] it may change depending on the outcome.
> [1] http://lists.kde.org/?t=140464151200002&r=1&w=2
>
>
> Diffs
> -----
>
> startkde/startkde.cmake 24610f4
>
> Diff: https://git.reviewboard.kde.org/r/119145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luca Beltrame
>
>
--===============6375279239768722277==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119145/">https://git.reviewboard.kde.org/r/119145/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">GenericDataLocation + env is polluting the global namespace. Imagine if \
gnome did the same...</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">My suggestion is GenericConfigLocation \
+ "/startkde/env/"<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> or GenericConfigLocation + \
"/kde-workspace/env/".</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Yes, this means adjusting the KCM as \
well, of course.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119145/diff/1/?file=287769#file287769line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startkde/startkde.cmake</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">for</span> <span class="err">prefix</span> <span class="err">in</span> \
<span class="err">`echo</span> <span class="err">"$libpath"</span> <span \
class="err">|</span> <span class="err">sed</span> <span class="err">-n</span> <span \
class="err">-e</span> <span class="err">'s,$,/env/,p'`;</span> <span \
class="err">do</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">concatenation doesn't really need sed.</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On July 6th, 2014, 12:52 p.m. UTC, Luca Beltrame wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and David Faure.</div>
<div>By Luca Beltrame.</div>
<p style="color: grey;"><i>Updated July 6, 2014, 12:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=333793">333793</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently env and shutdown scripts in startkde are not \
run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths \
aren't being found.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch moves things to qtpaths, \
putting things under GenericDataLocation + "env" (or "shutdown"). This is what the \
plasma-desktop KCM does, but according to the discussion in [1] it may change \
depending on the outcome.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">[1] \
http://lists.kde.org/?t=140464151200002&r=1&w=2</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/startkde.cmake <span style="color: grey">(24610f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119145/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6375279239768722277==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic