[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc
From: "David Faure" <faure () kde ! org>
Date: 2014-07-06 9:47:18
Message-ID: 20140706094718.15698.8355 () probe ! kde ! org
[Download RAW message or body]
--===============2635812239954807411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119142/
-----------------------------------------------------------
Review request for KDE Frameworks, Alex Merry and Kevin Ottens.
Repository: kxmlgui
Description
-------
KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc
The old files (DATADIR/component_name/file.rc) can still be loaded,
and a runtime warning is shown in such a case, telling people to install
into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d)
This keeps DATADIR slightly cleaner, getting rid of many application subdirs
that would just contain a rc file. Some people seem to care about the cleanliness
of their DATADIR :-)
Diffs
-----
src/kedittoolbar.cpp 32512e9caccdbee1b07ff791fbecdcc817ca5726
src/kxmlguiclient.cpp f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d
src/kxmlguifactory.cpp aa657bcc24a949f4350975609f19fae8b6c9a4f0
Diff: https://git.reviewboard.kde.org/r/119142/diff/
Testing
-------
Running kwrite unmodified -> works, with runtime warning
Porting kwrite to KXMLGUI_INSTALL_DIR -> works, runtime warning is gone
I also did the same with konsole, special case since it called \
setXMLFile("konsole/partui.rc"), had to be ported to setComponentName("konsole") + \
setXMLFile("partui.rc") while porting to KXMLGUI_INSTALL_DIR. This patch is still \
SC/BC, it's just a porting trap -- that affects none of the other existing kf5-based \
apps though.
Thanks,
David Faure
--===============2635812239954807411==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119142/">https://git.reviewboard.kde.org/r/119142/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Alex Merry and Kevin Ottens.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KXMLGUI: load .rc files from \
DATADIR/kxmlgui5/component_name/file.rc</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The old files \
(DATADIR/component_name/file.rc) can still be loaded,<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> and \
a runtime warning is shown in such a case, telling people to install<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This keeps DATADIR slightly cleaner, getting rid of \
many application subdirs<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> that would just contain a rc file. \
Some people seem to care about the cleanliness<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> of their DATADIR \
:-)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Running kwrite unmodified -> works, with runtime \
warning<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Porting kwrite to KXMLGUI_INSTALL_DIR -> works, \
runtime warning is gone</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I also did the same with konsole, \
special case since it called setXMLFile("konsole/partui.rc"), had to be ported to \
setComponentName("konsole") + setXMLFile("partui.rc") while porting to \
KXMLGUI_INSTALL_DIR. This patch is still SC/BC, it's just a porting trap -- that \
affects none of the other existing kf5-based apps though.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kedittoolbar.cpp <span style="color: \
grey">(32512e9caccdbee1b07ff791fbecdcc817ca5726)</span></li>
<li>src/kxmlguiclient.cpp <span style="color: \
grey">(f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d)</span></li>
<li>src/kxmlguifactory.cpp <span style="color: \
grey">(aa657bcc24a949f4350975609f19fae8b6c9a4f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119142/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2635812239954807411==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic