'Re: Review Request 119058: add a test case for KIconLoader::addAppDir()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 119058: add a test case for KIconLoader::addAppDir()
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-02 14:32:34
Message-ID: 20140702143234.22336.6539 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119058/#review61493
-----------------------------------------------------------

This review has been submitted with commit f33e3283a02eebb468dacae8d1fce70ac1f74715 \
by Marco Martin to branch master.

- Commit Hook

On July 2, 2014, 9 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119058/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 9 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> when the theme is not complete, KIconLoader::addAppDir may break the fallback to \
> the default themeof icons to the default theme. this test case shhows the breakage.
> commenting out addAppDir() makes the test pass.
> 
> 
> Diffs
> -----
> 
> autotests/CMakeLists.txt 798509d 
> autotests/breeze.theme PRE-CREATION 
> autotests/kiconloader_unittest.cpp d4ec842 
> autotests/resources.qrc 33c2510 
> 
> Diff: https://git.reviewboard.kde.org/r/119058/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119058/">https://git.reviewboard.kde.org/r/119058/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f33e3283a02eebb468dacae8d1fce70ac1f74715 by Marco Martin to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 2nd, 2014, 9 a.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated July 2, 2014, 9 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">when the theme is not complete, KIconLoader::addAppDir may break the \
fallback to the default themeof icons to the default theme. this test case shhows the \
breakage. commenting out addAppDir() makes the test pass.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(798509d)</span></li>

 <li>autotests/breeze.theme <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/kiconloader_unittest.cpp <span style="color: \
grey">(d4ec842)</span></li>

 <li>autotests/resources.qrc <span style="color: grey">(33c2510)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119058/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 