'Re: Review Request 119074: Fix reading of XDG style semicolon separated lists with escaped '; ''

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 119074: Fix reading of XDG style semicolon separated lists with escaped '; '
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-01 18:50:27
Message-ID: 20140701185027.22318.41986 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119074/#review61418
-----------------------------------------------------------

This review has been submitted with commit ae51450ea64970dcdc544185d68e1e73fb390caa \
by Alex Richardson to branch master.

- Commit Hook

On July 1, 2014, 6:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119074/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Previously the warning "Invalid escape sequence "\;"." would appear and
> "\;" was replaced with just the backslash as is done for all
> unrecognized escape sequences. Keep both characters so that
> readXdgListEntry() works with values containing semicolons
> 
> 
> Diffs
> -----
> 
> autotests/kdesktopfiletest.cpp b1938b80bd8006b45068613e0c1e7ad980287f34 
> autotests/kconfigtest.cpp 5f2c798902ea3e8c8207a744ae59f706be2694ed 
> autotests/kconfigtest.h f2897a8f2497d4d84d292d7fbc30641e4adfeb83 
> src/core/kconfigini.cpp 5fe4de032c5d42559962c078b988bfcff52c8960 
> 
> Diff: https://git.reviewboard.kde.org/r/119074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119074/">https://git.reviewboard.kde.org/r/119074/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ae51450ea64970dcdc544185d68e1e73fb390caa by Alex Richardson to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 1st, 2014, 6:35 p.m. UTC, Alexander Richardson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Alexander Richardson.</div>

<p style="color: grey;"><i>Updated July 1, 2014, 6:35 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously the warning &quot;Invalid escape sequence \
&quot;\;&quot;.&quot; would appear and &quot;\;&quot; was replaced with just the \
backslash as is done for all unrecognized escape sequences. Keep both characters so \
that readXdgListEntry() works with values containing semicolons</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kdesktopfiletest.cpp <span style="color: \
grey">(b1938b80bd8006b45068613e0c1e7ad980287f34)</span></li>

 <li>autotests/kconfigtest.cpp <span style="color: \
grey">(5f2c798902ea3e8c8207a744ae59f706be2694ed)</span></li>

 <li>autotests/kconfigtest.h <span style="color: \
grey">(f2897a8f2497d4d84d292d7fbc30641e4adfeb83)</span></li>

 <li>src/core/kconfigini.cpp <span style="color: \
grey">(5fe4de032c5d42559962c078b988bfcff52c8960)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119074/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 